This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2989

context: drop support for changeid of type long (API?)
ClosedPublic

Authored by martinvonz on Mar 31 2018, 2:00 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG97ab6f2dc3c3: context: drop support for changeid of type long (API?)
Summary

I don't see a reason to support type long. It's pretty much the same
type as int. There was some discussion about it on the mailing list
around the time of ff2f90503d64 (context: work around long not
existing on Python 3, 2017-03-11), but I couldn't find a good reason
to keep it. There was some mention of hgtk doing "repo[long(rev)]",
but that was in 2012.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 31 2018, 2:00 AM
yuja accepted this revision.Mar 31 2018, 6:13 AM
This revision is now accepted and ready to land.Mar 31 2018, 6:13 AM
Closed by commit rHG97ab6f2dc3c3: context: drop support for changeid of type long (API?) (authored by martinvonz). · Explain WhyMar 31 2018, 6:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 7456

mercurial/context.py

if changeid == '': if changeid == '':
changeid = '.' changeid = '.'
try: try:
if isinstance(changeid, int): if isinstance(changeid, int):
self._node = repo.changelog.node(changeid) self._node = repo.changelog.node(changeid)
self._rev = changeid self._rev = changeid
return return
if not pycompat.ispy3 and isinstance(changeid, long):
changeid = "%d" % changeid
if changeid == 'null': if changeid == 'null':
self._node = nullid self._node = nullid
self._rev = nullrev self._rev = nullrev
return return
if changeid == 'tip': if changeid == 'tip':
self._node = repo.changelog.tip() self._node = repo.changelog.tip()
self._rev = repo.changelog.rev(self._node) self._rev = repo.changelog.rev(self._node)
return return