This is an archive of the discontinued Mercurial Phabricator instance.

addremove: remove dry_run, similarity from scmutil.addremove
ClosedPublic

Authored by khanchi97 on Mar 31 2018, 2:27 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

khanchi97 created this revision.Mar 31 2018, 2:27 PM
khanchi97 added a subscriber: yuja.Mar 31 2018, 2:37 PM

I ran all the tests those are related to addremove and they are passing.

yuja requested changes to this revision.Mar 31 2018, 9:56 PM

Sorry, I didn't notice that the opts dict carries extra options other
than subrepos, dry_run, and similarity. Because of that, my idea of
dropping opts turns out to be worse than the current state.

Maybe we can get rid of dry_run and similarity instead, but we'll
have to be careful since the default similarity value varies on command.

mercurial/commands.py
252

Oops, largefiles options in core.

This revision now requires changes to proceed.Mar 31 2018, 9:56 PM
khanchi97 retitled this revision from addremove: remove opts from scmutil.addremove to addremove: remove dry_run, similarity from scmutil.addremove.Apr 1 2018, 6:44 AM
khanchi97 updated this revision to Diff 7500.

okay, so I have sent another revision which removes dry_run and
similarity from scmutil.addremove

yuja requested changes to this revision.Apr 2 2018, 10:53 AM

Other than that, the patch looks good to me. Thanks!

contrib/perf.py
426

Here opts['dry_run'] must be set.

This revision now requires changes to proceed.Apr 2 2018, 10:53 AM
khanchi97 updated this revision to Diff 7523.Apr 2 2018, 5:26 PM
khanchi97 updated this revision to Diff 7524.Apr 2 2018, 5:29 PM
yuja accepted this revision.Apr 3 2018, 8:19 AM
This revision is now accepted and ready to land.Apr 3 2018, 8:19 AM
This revision was automatically updated to reflect the committed changes.