This is an archive of the discontinued Mercurial Phabricator instance.

peer: make ui an attribute
ClosedPublic

Authored by indygreg on Apr 3 2018, 10:00 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe826fe7a08c7: peer: make ui an attribute
Summary

With abc interfaces, instance attributes could not satisfy
@abc.abstractproperty requirements because interface conformance
was tested at type creation time. When we created the abc
peer interfaces, we had to make "ui" a @property to satisfy
abc.

Now that peer interfaces are using zope.interface and there is no
import time validation (but there are tests validating instances
conform to the interface), we can go back to using regular object
attributes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 3 2018, 10:00 PM
This revision was automatically updated to reflect the committed changes.