This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3142

narrow: remove unused "cacheprop" stuff
ClosedPublic

Authored by martinvonz on Apr 5 2018, 3:42 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGc3c76194f0c1: narrow: remove unused "cacheprop" stuff
Summary

This is unused since D3046. I didn't even notice it then, but tests
still pass so I hope it's still handled safely.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 5 2018, 3:42 PM
durin42 accepted this revision.Apr 5 2018, 6:55 PM
This revision is now accepted and ready to land.Apr 5 2018, 6:55 PM
Closed by commit rHGc3c76194f0c1: narrow: remove unused "cacheprop" stuff (authored by martinvonz). · Explain WhyApr 5 2018, 6:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/narrow/narrowrepo.py (10 lines)

Diff 7758

hgext/narrow/narrowrepo.py

# narrowrepo.py - repository which supports narrow revlogs, lazy loading # narrowrepo.py - repository which supports narrow revlogs, lazy loading
# #
# Copyright 2017 Google, Inc. # Copyright 2017 Google, Inc.
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
from mercurial import ( from mercurial import (
bundlerepo,
changegroup, changegroup,
hg, hg,
localrepo,
narrowspec, narrowspec,
scmutil, scmutil,
) )
from . import ( from . import (
narrowrevlog, narrowrevlog,
) )
spec = f.read() spec = f.read()
with repo.vfs(narrowspec.FILENAME, 'w') as f: with repo.vfs(narrowspec.FILENAME, 'w') as f:
f.write(spec) f.write(spec)
return orig(ui, repo, repopath) return orig(ui, repo, repopath)
def wraprepo(repo): def wraprepo(repo):
"""Enables narrow clone functionality on a single local repository.""" """Enables narrow clone functionality on a single local repository."""
cacheprop = localrepo.storecache
if isinstance(repo, bundlerepo.bundlerepository):
# We have to use a different caching property decorator for
# bundlerepo because storecache blows up in strange ways on a
# bundlerepo. Fortunately, there's no risk of data changing in
# a bundlerepo.
cacheprop = lambda name: localrepo.unfilteredpropertycache
class narrowrepository(repo.__class__): class narrowrepository(repo.__class__):
def file(self, f): def file(self, f):
fl = super(narrowrepository, self).file(f) fl = super(narrowrepository, self).file(f)
narrowrevlog.makenarrowfilelog(fl, self.narrowmatch()) narrowrevlog.makenarrowfilelog(fl, self.narrowmatch())
return fl return fl
# I'm not sure this is the right place to do this filter. # I'm not sure this is the right place to do this filter.