This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3156

githelp: use revsymbol() for looking up symbol
ClosedPublic

Authored by martinvonz on Apr 6 2018, 3:08 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG764ada920db5: githelp: use revsymbol() for looking up symbol
Summary

I don't know if we should be using revsingle() here, so I was
conservative and switched to revsymbol().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 6 2018, 3:08 AM
Closed by commit rHG764ada920db5: githelp: use revsymbol() for looking up symbol (authored by martinvonz). · Explain WhyApr 6 2018, 8:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/githelp.py (3 lines)

Diff 7778

hgext/githelp.py

import re import re
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
encoding, encoding,
error, error,
fancyopts, fancyopts,
registrar, registrar,
scmutil,
) )
from mercurial.utils import ( from mercurial.utils import (
procutil, procutil,
) )
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
def ispath(repo, string): def ispath(repo, string):
""" """
The first argument to git checkout can either be a revision or a path. Let's The first argument to git checkout can either be a revision or a path. Let's
generally assume it's a revision, unless it's obviously a path. There are generally assume it's a revision, unless it's obviously a path. There are
too many ways to spell revisions in git for us to reasonably catch all of too many ways to spell revisions in git for us to reasonably catch all of
them, so let's be conservative. them, so let's be conservative.
""" """
if string in repo: if scmutil.isrevsymbol(repo, string):
# if it's definitely a revision let's not even check if a file of the # if it's definitely a revision let's not even check if a file of the
# same name exists. # same name exists.
return False return False
cwd = repo.getcwd() cwd = repo.getcwd()
if cwd == '': if cwd == '':
repopath = string repopath = string
else: else: