This is an archive of the discontinued Mercurial Phabricator instance.

debugcommands: ability to suppress logging of handshake
ClosedPublic

Authored by indygreg on Apr 14 2018, 8:21 PM.

Details

Summary

The tests for calling wire protocol commands were getting quite
verbose because they included the results of the capabilities
request. Furthermore, it was annoying to have to update several
tests every time the capabilities response changed.

The only tests that really care about the low-level details of
the capabilities requests are those testing the protocol
handshake. And those are mostly not instantiating peer instances
or are contained to limited files.

This commit adds an option to hg debugwireproto to suppress logging
of the handshake. The shell helper function to perform HTTP tests
has been updated to use this by default. Lots of excessive test
output has gone away.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 14 2018, 8:21 PM
durin42 accepted this revision.Apr 16 2018, 6:51 PM
This revision is now accepted and ready to land.Apr 16 2018, 6:51 PM
This revision was automatically updated to reflect the committed changes.