This is an archive of the discontinued Mercurial Phabricator instance.

revset: make id() an empty set for ambiguous nodeid (BC)
ClosedPublic

Authored by martinvonz on May 7 2018, 6:18 PM.

Details

Summary

As Yuya pointed out in the review of D3311, id() (and rev()) does not
raise an error when the input is an unknown identifier, so it doesn't
make sense for it to do that when the input is ambiguous with a
filtered node. However, it turned out that it already does raise an
error when the input is ambiguous among the visible nodes. So let's
start by fixing that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.May 7 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.