This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3498

revlog: use literal -1 instead of variable that always has that value
ClosedPublic

Authored by martinvonz on May 8 2018, 2:07 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG892592475094: revlog: use literal -1 instead of variable that always has that value
Summary

We were setting "ntrev" to "rev", but "rev" was always -1 at the end
of the loop, so it's clearer to use a literal -1.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (2 lines)

Diff 8551

mercurial/cext/revlog.c

if (self->ntrev > 0) { if (self->ntrev > 0) {
for (rev = self->ntrev - 1; rev >= 0; rev--) { for (rev = self->ntrev - 1; rev >= 0; rev--) {
const char *n = index_node_existing(self, rev); const char *n = index_node_existing(self, rev);
if (n == NULL) if (n == NULL)
return -1; return -1;
if (nt_insert(self, n, rev) == -1) if (nt_insert(self, n, rev) == -1)
return -1; return -1;
} }
self->ntrev = rev; self->ntrev = -1;
} }
return 0; return 0;
} }
static int nt_partialmatch(indexObject *self, const char *node, static int nt_partialmatch(indexObject *self, const char *node,
Py_ssize_t nodelen) Py_ssize_t nodelen)
{ {
if (nt_init(self) == -1) if (nt_init(self) == -1)