This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3520

remotenames: enable the storage config option if extension is enabled
ClosedPublic

Authored by pulkit on May 10 2018, 9:29 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb9e6b71dc272: remotenames: enable the storage config option if extension is enabled
Summary

Before this patch, the config option to store remotenames was set to False by
default and remotenames extension does not set it True. So if you enable
remotenames extension without setting 'experimental.remotenames=True', you won't
get the remotenames.

This patch makes remotenames enable the config option if then extension is
enabled which makes sense.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 10 2018, 9:29 AM
Closed by commit rHGb9e6b71dc272: remotenames: enable the storage config option if extension is enabled (authored by pulkit). · Explain WhyMay 11 2018, 10:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/remotenames.py (4 lines)
Mtests/test-logexchange.t (2 lines)

Diff 8651

hgext/remotenames.py

bmarks[name] = (node, ' ', '') bmarks[name] = (node, ' ', '')
return orig(ui, repo, bmarks, **opts) return orig(ui, repo, bmarks, **opts)
def extsetup(ui): def extsetup(ui):
extensions.wrapfunction(bookmarks, '_printbookmarks', wrapprintbookmarks) extensions.wrapfunction(bookmarks, '_printbookmarks', wrapprintbookmarks)
def reposetup(ui, repo): def reposetup(ui, repo):
# set the config option to store remotenames
repo.ui.setconfig('experimental', 'remotenames', True, 'remotenames-ext')
if not repo.local(): if not repo.local():
return return
repo._remotenames = remotenames(repo) repo._remotenames = remotenames(repo)
ns = namespaces.namespace ns = namespaces.namespace
if ui.configbool('remotenames', 'bookmarks'): if ui.configbool('remotenames', 'bookmarks'):
remotebookmarkns = ns( remotebookmarkns = ns(

tests/test-logexchange.t

Testing the functionality to pull remotenames Testing the functionality to pull remotenames
============================================= =============================================
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [ui] > [ui]
> ssh = $PYTHON "$TESTDIR/dummyssh" > ssh = $PYTHON "$TESTDIR/dummyssh"
> [alias] > [alias]
> glog = log -G -T '{rev}:{node|short} {desc}' > glog = log -G -T '{rev}:{node|short} {desc}'
> [experimental]
> remotenames = True
> [extensions] > [extensions]
> remotenames = > remotenames =
> show = > show =
> EOF > EOF
Making a server repo Making a server repo
-------------------- --------------------