This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3530

revlog: handle error from node lookup
ClosedPublic

Authored by martinvonz on May 11 2018, 10:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG312d7d14d44e: revlog: handle error from node lookup
Summary

I missed this in D3499. Thanks to Yuya for spotting it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 11 2018, 10:33 AM
martinvonz updated this revision to Diff 8636.May 11 2018, 12:09 PM
Closed by commit rHG312d7d14d44e: revlog: handle error from node lookup (authored by martinvonz). · Explain WhyMay 11 2018, 10:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (4 lines)

Diff 8647

mercurial/cext/revlog.c

for (level = off = 0; level < 40; level++) { for (level = off = 0; level < 40; level++) {
int k, v; int k, v;
nodetree *n = &self->nt[off]; nodetree *n = &self->nt[off];
k = nt_level(node, level); k = nt_level(node, level);
v = n->children[k]; v = n->children[k];
if (v < 0) { if (v < 0) {
const char *n; const char *n;
v = -(v + 1); v = -(v + 1);
n = index_node(self, v); n = index_node_existing(self, v);
if (n == NULL)
return -3;
if (memcmp(node, n, 20) != 0) if (memcmp(node, n, 20) != 0)
/* /*
* Found a unique prefix, but it wasn't for the * Found a unique prefix, but it wasn't for the
* requested node (i.e the requested node does * requested node (i.e the requested node does
* not exist). * not exist).
*/ */
return -2; return -2;
return level + 1; return level + 1;