This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3531

shortest: avoid magic number "41"
ClosedPublic

Authored by martinvonz on May 11 2018, 12:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5ac72e07692a: shortest: avoid magic number "41"
Summary

As suggested by Yuya. Feel free to fold into D3502.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.May 11 2018, 12:16 PM
Closed by commit rHG5ac72e07692a: shortest: avoid magic number "41" (authored by martinvonz). · Explain WhyMay 11 2018, 10:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 8637

mercurial/scmutil.py

return False return False
return True return True
except ValueError: except ValueError:
return False return False
def disambiguate(prefix): def disambiguate(prefix):
"""Disambiguate against revnums.""" """Disambiguate against revnums."""
hexnode = hex(node) hexnode = hex(node)
for length in range(len(prefix), 41): for length in range(len(prefix), len(hexnode) + 1):
prefix = hexnode[:length] prefix = hexnode[:length]
if not isrev(prefix): if not isrev(prefix):
return prefix return prefix
try: try:
return disambiguate(cl.shortest(node, minlength)) return disambiguate(cl.shortest(node, minlength))
except error.LookupError: except error.LookupError:
raise error.RepoLookupError() raise error.RepoLookupError()