This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3562

tests: mark tests that fail when using chg as #require no-chg
ClosedPublic

Authored by spectral on May 15 2018, 2:52 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG538e850ae737: tests: mark tests that fail when using chg as #require no-chg
Summary

As far as I can tell, most of these failures are due to using $HGPORT, which it
seems chg might be using itself? I don't know enough to debug these failures to
fix them properly.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.May 15 2018, 2:52 PM
yuja added a subscriber: yuja.May 16 2018, 8:07 AM

Queued, thanks.

REVISION SUMMARY

As far as I can tell, most of these failures are due to using $HGPORT, which it
seems chg might be using itself? I don't know enough to debug these failures to
fix them properly.

Perhaps some "chg serve -d" calls would bypass the hack to execute
"hg serve -d" instead. Daemon processes can't be spawned from command server.

https://www.mercurial-scm.org/repo/hg/file/4.6/contrib/chg/chg.c#l363

Closed by commit rHG538e850ae737: tests: mark tests that fail when using chg as #require no-chg (authored by spectral). · Explain WhyMay 16 2018, 8:08 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8714

tests/test-clone-uncompressed.t

#require serve no-reposimplestore #require serve no-reposimplestore no-chg
#testcases stream-legacy stream-bundle2 #testcases stream-legacy stream-bundle2
#if stream-bundle2 #if stream-bundle2
$ cat << EOF >> $HGRCPATH $ cat << EOF >> $HGRCPATH
> [experimental] > [experimental]
> bundle2.stream = yes > bundle2.stream = yes
> EOF > EOF

tests/test-clonebundles.t

#require no-reposimplestore #require no-reposimplestore no-chg
Set up a server Set up a server
$ hg init server $ hg init server
$ cd server $ cd server
$ cat >> .hg/hgrc << EOF $ cat >> .hg/hgrc << EOF
> [extensions] > [extensions]
> clonebundles = > clonebundles =

tests/test-http-api-httpv2.t

#require no-chg
$ . $TESTDIR/wireprotohelpers.sh $ . $TESTDIR/wireprotohelpers.sh
$ enabledummycommands $ enabledummycommands
$ hg init server $ hg init server
$ cat > server/.hg/hgrc << EOF $ cat > server/.hg/hgrc << EOF
> [experimental] > [experimental]
> web.apiserver = true > web.apiserver = true
> EOF > EOF

tests/test-http-api.t

#require no-chg
$ send() { $ send() {
> hg --verbose debugwireproto --peer raw http://$LOCALIP:$HGPORT/ > hg --verbose debugwireproto --peer raw http://$LOCALIP:$HGPORT/
> } > }
$ hg init server $ hg init server
$ hg -R server serve -p $HGPORT -d --pid-file hg.pid $ hg -R server serve -p $HGPORT -d --pid-file hg.pid
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS

tests/test-http-protocol.t

#require no-chg
$ . $TESTDIR/wireprotohelpers.sh $ . $TESTDIR/wireprotohelpers.sh
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [web] > [web]
> push_ssl = false > push_ssl = false
> allow_push = * > allow_push = *
> EOF > EOF

tests/test-lfs-largefiles.t

#require no-reposimplestore #require no-reposimplestore no-chg
This tests the interaction between the largefiles and lfs extensions, and This tests the interaction between the largefiles and lfs extensions, and
conversion from largefiles -> lfs. conversion from largefiles -> lfs.
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [extensions] > [extensions]
> largefiles = > largefiles =
> >

tests/test-lfs-serve-access.t

#require serve no-reposimplestore #require serve no-reposimplestore no-chg
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [extensions] > [extensions]
> lfs= > lfs=
> [lfs] > [lfs]
> track=all() > track=all()
> [web] > [web]
> push_ssl = False > push_ssl = False

tests/test-lfs-serve.t

#testcases lfsremote-on lfsremote-off #testcases lfsremote-on lfsremote-off
#require serve no-reposimplestore #require serve no-reposimplestore no-chg
This test splits `hg serve` with and without using the extension into separate This test splits `hg serve` with and without using the extension into separate
tests cases. The tests are broken down as follows, where "LFS"/"No-LFS" tests cases. The tests are broken down as follows, where "LFS"/"No-LFS"
indicates whether or not there are commits that use an LFS file, and "D"/"E" indicates whether or not there are commits that use an LFS file, and "D"/"E"
indicates whether or not the extension is loaded. The "X" cases are not tested indicates whether or not the extension is loaded. The "X" cases are not tested
individually, because the lfs requirement causes the process to bail early if individually, because the lfs requirement causes the process to bail early if
the extension is disabled. the extension is disabled.

tests/test-lfs-test-server.t

#require no-reposimplestore #require no-reposimplestore no-chg
#testcases git-server hg-server #testcases git-server hg-server
#if git-server #if git-server
#require lfs-test-server #require lfs-test-server
#else #else
#require serve #require serve
#endif #endif

tests/test-lfs.t

#require no-reposimplestore #require no-reposimplestore no-chg
# Initial setup # Initial setup
$ cat >> $HGRCPATH << EOF $ cat >> $HGRCPATH << EOF
> [extensions] > [extensions]
> lfs= > lfs=
> [lfs] > [lfs]
> # Test deprecated config > # Test deprecated config

tests/test-parseindex.t

#require no-chg
revlog.parseindex must be able to parse the index file even if revlog.parseindex must be able to parse the index file even if
an index entry is split between two 64k blocks. The ideal test an index entry is split between two 64k blocks. The ideal test
would be to create an index file with inline data where would be to create an index file with inline data where
64k < size < 64k + 64 (64k is the size of the read buffer, 64 is 64k < size < 64k + 64 (64k is the size of the read buffer, 64 is
the size of an index entry) and with an index entry starting right the size of an index entry) and with an index entry starting right
before the 64k block boundary, and try to read it. before the 64k block boundary, and try to read it.
We approximate that by reducing the read buffer to 1 byte. We approximate that by reducing the read buffer to 1 byte.

tests/test-pull-bundle.t

#require no-chg
$ hg init repo $ hg init repo
$ cd repo $ cd repo
$ echo foo > foo $ echo foo > foo
$ hg ci -qAm 'add foo' $ hg ci -qAm 'add foo'
$ echo >> foo $ echo >> foo
$ hg ci -m 'change foo' $ hg ci -m 'change foo'
$ hg up -qC 0 $ hg up -qC 0
$ echo bar > bar $ echo bar > bar

tests/test-push-http.t

#require no-chg
#testcases bundle1 bundle2 #testcases bundle1 bundle2
#if bundle1 #if bundle1
$ cat << EOF >> $HGRCPATH $ cat << EOF >> $HGRCPATH
> [devel] > [devel]
> # This test is dedicated to interaction through old bundle > # This test is dedicated to interaction through old bundle
> legacy.exchange = bundle1 > legacy.exchange = bundle1
> EOF > EOF

tests/test-ssh-proto.t

#require no-chg
$ cat > hgrc-sshv2 << EOF $ cat > hgrc-sshv2 << EOF
> %include $HGRCPATH > %include $HGRCPATH
> [experimental] > [experimental]
> sshpeer.advertise-v2 = true > sshpeer.advertise-v2 = true
> sshserver.support-v2 = true > sshserver.support-v2 = true
> EOF > EOF
Helper function to run protocol tests against multiple protocol versions. Helper function to run protocol tests against multiple protocol versions.

tests/test-wireproto-command-capabilities.t

#require no-chg
$ . $TESTDIR/wireprotohelpers.sh $ . $TESTDIR/wireprotohelpers.sh
$ hg init server $ hg init server
zstd isn't present in plain builds. Make tests easier by removing zstd isn't present in plain builds. Make tests easier by removing
zstd from the equation. zstd from the equation.
$ cat >> server/.hg/hgrc << EOF $ cat >> server/.hg/hgrc << EOF