This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3564

py3: add b'' prefixes in tests/test-extension.t
ClosedPublic

Authored by pulkit on May 15 2018, 4:41 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGa9ffb4a577d0: py3: add b'' prefixes in tests/test-extension.t
Summary
  1. skip-blame because just b'' prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 15 2018, 4:41 PM
Closed by commit rHGa9ffb4a577d0: py3: add b'' prefixes in tests/test-extension.t (authored by pulkit). · Explain WhyMay 16 2018, 7:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-extension.t (12 lines)

Diff 8711

tests/test-extension.t

> >
> def uisetup(ui): > def uisetup(ui):
> result = [] > result = []
> result.append(lused.detail) > result.append(lused.detail)
> result.append(lfunc()) > result.append(lfunc())
> result.append(absdetail) > result.append(absdetail)
> result.append(legacydetail) > result.append(legacydetail)
> result.append(proxied.detail) > result.append(proxied.detail)
> ui.write('LIB: %s\n' % '\nLIB: '.join(result)) > ui.write(b'LIB: %s\n' % '\nLIB: '.join(result))
> EOF > EOF
Examine module importing. Examine module importing.
$ (PYTHONPATH=${PYTHONPATH}${PATHSEP}${TESTTMP}; hg --config extensions.absextroot=$TESTTMP/absextroot showabsolute) $ (PYTHONPATH=${PYTHONPATH}${PATHSEP}${TESTTMP}; hg --config extensions.absextroot=$TESTTMP/absextroot showabsolute)
LIB: this is extlibroot.lsub1.lsub2.used LIB: this is extlibroot.lsub1.lsub2.used
LIB: this is extlibroot.lsub1.lsub2.called.func() LIB: this is extlibroot.lsub1.lsub2.called.func()
LIB: this is extlibroot.recursedown.abs.used LIB: this is extlibroot.recursedown.abs.used
** Please disable throw and try your action again. ** Please disable throw and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw
If the extensions declare outdated versions, accuse the older extension first: If the extensions declare outdated versions, accuse the older extension first:
$ echo "from mercurial import util" >> older.py $ echo "from mercurial import util" >> older.py
$ echo "util.version = lambda:'2.2'" >> older.py $ echo "util.version = lambda:b'2.2'" >> older.py
$ echo "testedwith = b'1.9.3'" >> older.py $ echo "testedwith = b'1.9.3'" >> older.py
$ echo "testedwith = b'2.1.1'" >> throw.py $ echo "testedwith = b'2.1.1'" >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension older ** Unknown exception encountered with possibly-broken third-party extension older
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
Copyright (C) 2005-* Matt Mackall and others (glob) Copyright (C) 2005-* Matt Mackall and others (glob)
This is free software; see the source for copying conditions. There is NO This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Enabled extensions: Enabled extensions:
throw external 1.2.3 throw external 1.2.3
$ echo 'getversion = lambda: "1.twentythree"' >> throw.py $ echo 'getversion = lambda: b"1.twentythree"' >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg version -v --config extensions.throw=throw.py --config extensions.strip= $ hg version -v --config extensions.throw=throw.py --config extensions.strip=
Mercurial Distributed SCM (version *) (glob) Mercurial Distributed SCM (version *) (glob)
(see https://mercurial-scm.org for more information) (see https://mercurial-scm.org for more information)
Copyright (C) 2005-* Matt Mackall and others (glob) Copyright (C) 2005-* Matt Mackall and others (glob)
This is free software; see the source for copying conditions. There is NO This is free software; see the source for copying conditions. There is NO
Test synopsis and docstring extending Test synopsis and docstring extending
$ hg init exthelp $ hg init exthelp
$ cat > exthelp.py <<EOF $ cat > exthelp.py <<EOF
> from mercurial import commands, extensions > from mercurial import commands, extensions
> def exbookmarks(orig, *args, **opts): > def exbookmarks(orig, *args, **opts):
> return orig(*args, **opts) > return orig(*args, **opts)
> def uisetup(ui): > def uisetup(ui):
> synopsis = ' GREPME [--foo] [-x]' > synopsis = b' GREPME [--foo] [-x]'
> docstring = ''' > docstring = '''
> GREPME make sure that this is in the help! > GREPME make sure that this is in the help!
> ''' > '''
> extensions.wrapcommand(commands.table, b'bookmarks', exbookmarks, > extensions.wrapcommand(commands.table, b'bookmarks', exbookmarks,
> synopsis, docstring) > synopsis, docstring)
> EOF > EOF
$ abspath=`pwd`/exthelp.py $ abspath=`pwd`/exthelp.py
$ echo '[extensions]' >> $HGRCPATH $ echo '[extensions]' >> $HGRCPATH
Prohibit the use of unicode strings as the default value of options Prohibit the use of unicode strings as the default value of options
$ hg init $TESTTMP/opt-unicode-default $ hg init $TESTTMP/opt-unicode-default
$ cat > $TESTTMP/test_unicode_default_value.py << EOF $ cat > $TESTTMP/test_unicode_default_value.py << EOF
> from mercurial import registrar > from mercurial import registrar
> cmdtable = {} > cmdtable = {}
> command = registrar.command(cmdtable) > command = registrar.command(cmdtable)
> @command(b'dummy', [('', 'opt', u'value', u'help')], 'ext [OPTIONS]') > @command(b'dummy', [(b'', b'opt', u'value', u'help')], 'ext [OPTIONS]')
> def ext(*args, **opts): > def ext(*args, **opts):
> print(opts['opt']) > print(opts[b'opt'])
> EOF > EOF
$ cat > $TESTTMP/opt-unicode-default/.hg/hgrc << EOF $ cat > $TESTTMP/opt-unicode-default/.hg/hgrc << EOF
> [extensions] > [extensions]
> test_unicode_default_value = $TESTTMP/test_unicode_default_value.py > test_unicode_default_value = $TESTTMP/test_unicode_default_value.py
> EOF > EOF
$ hg -R $TESTTMP/opt-unicode-default dummy $ hg -R $TESTTMP/opt-unicode-default dummy
*** failed to import extension test_unicode_default_value from $TESTTMP/test_unicode_default_value.py: unicode u'value' found in cmdtable.dummy *** failed to import extension test_unicode_default_value from $TESTTMP/test_unicode_default_value.py: unicode u'value' found in cmdtable.dummy
*** (use b'' to make it byte string) *** (use b'' to make it byte string)
hg: unknown command 'dummy' hg: unknown command 'dummy'
(did you mean summary?) (did you mean summary?)
[255] [255]