This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3589

pathencode: improve error messages slightly
ClosedPublic

Authored by durin42 on May 18 2018, 8:51 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG9aaa74f9eb87: pathencode: improve error messages slightly
Summary

Both of these are conditions we should never hit, so we can afford to
be more verbose to make debugging less baffling.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 18 2018, 8:51 PM
Closed by commit rHG9aaa74f9eb87: pathencode: improve error messages slightly (authored by durin42). · Explain WhyMay 18 2018, 10:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/pathencode.c (5 lines)

Diff 8760

mercurial/cext/pathencode.c

if (name == NULL) if (name == NULL)
return -1; return -1;
hashlib = PyImport_ImportModule("hashlib"); hashlib = PyImport_ImportModule("hashlib");
Py_DECREF(name); Py_DECREF(name);
if (hashlib == NULL) { if (hashlib == NULL) {
PyErr_SetString(PyExc_ImportError, "hashlib"); PyErr_SetString(PyExc_ImportError,
"pathencode failed to find hashlib");
return -1; return -1;
} }
shafunc = PyObject_GetAttrString(hashlib, "sha1"); shafunc = PyObject_GetAttrString(hashlib, "sha1");
Py_DECREF(hashlib); Py_DECREF(hashlib);
if (shafunc == NULL) { if (shafunc == NULL) {
PyErr_SetString(PyExc_AttributeError, PyErr_SetString(PyExc_AttributeError,
"module 'hashlib' has no " "module 'hashlib' has no "
"attribute 'sha1'"); "attribute 'sha1' in pathencode");
return -1; return -1;
} }
} }
shaobj = PyObject_CallFunction(shafunc, PY23("s#", "y#"), str, len); shaobj = PyObject_CallFunction(shafunc, PY23("s#", "y#"), str, len);
if (shaobj == NULL) if (shaobj == NULL)
return -1; return -1;