This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3613

py3: use `except error as e` instead of `except error, e`
ClosedPublic

Authored by pulkit on May 19 2018, 10:41 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf0fadc5bea21: py3: use `except error as e` instead of `except error, e`
Summary

The latter throws SyntaxError on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 19 2018, 10:41 AM
Closed by commit rHGf0fadc5bea21: py3: use `except error as e` instead of `except error, e` (authored by pulkit). · Explain WhyMay 19 2018, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-parseindex.t (2 lines)

Diff 8818

tests/test-parseindex.t

> ('find_gca_candidates', lambda: cl.commonancestorsheads(n0, n1)), > ('find_gca_candidates', lambda: cl.commonancestorsheads(n0, n1)),
> ('find_deepest', lambda: cl.ancestor(n0, n1)), > ('find_deepest', lambda: cl.ancestor(n0, n1)),
> ] > ]
> for l, f in ops: > for l, f in ops:
> print(l + ':', end=' ') > print(l + ':', end=' ')
> try: > try:
> f() > f()
> print('uncaught buffer overflow?') > print('uncaught buffer overflow?')
> except ValueError, inst: > except ValueError as inst:
> print(inst) > print(inst)
> EOF > EOF
$ $PYTHON test.py limit/.hg/store $ $PYTHON test.py limit/.hg/store
reachableroots: parent out of range reachableroots: parent out of range
compute_phases_map_sets: parent out of range compute_phases_map_sets: parent out of range
index_headrevs: parent out of range index_headrevs: parent out of range
find_gca_candidates: parent out of range find_gca_candidates: parent out of range