This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3618

pathencode: remove unused variable
ClosedPublic

Authored by durin42 on May 19 2018, 3:16 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf7a0398996ad: pathencode: remove unused variable
rHGf9eaa5cd9ee9: pathencode: remove unused variable
Summary

Caught by Yuya during review of 92ac9cf78dba.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 19 2018, 3:16 PM
indygreg accepted this revision.May 21 2018, 2:37 PM
This revision is now accepted and ready to land.May 21 2018, 2:37 PM
Closed by commit rHGf9eaa5cd9ee9: pathencode: remove unused variable (authored by durin42). · Explain WhyMay 21 2018, 2:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/pathencode.c (9 lines)

Diff 8861

mercurial/cext/pathencode.c

* but we don't encounter enough long names to be worth the code. * but we don't encounter enough long names to be worth the code.
*/ */
static int sha1hash(char hash[20], const char *str, Py_ssize_t len) static int sha1hash(char hash[20], const char *str, Py_ssize_t len)
{ {
static PyObject *shafunc; static PyObject *shafunc;
PyObject *shaobj, *hashobj; PyObject *shaobj, *hashobj;
if (shafunc == NULL) { if (shafunc == NULL) {
PyObject *hashlib, *name = PyBytes_FromString("hashlib"); PyObject *hashlib = PyImport_ImportModule("hashlib");
if (name == NULL)
return -1;
hashlib = PyImport_ImportModule("hashlib");
Py_DECREF(name);
if (hashlib == NULL) { if (hashlib == NULL) {
PyErr_SetString(PyExc_ImportError, PyErr_SetString(PyExc_ImportError,
"pathencode failed to find hashlib"); "pathencode failed to find hashlib");
return -1; return -1;
} }
shafunc = PyObject_GetAttrString(hashlib, "sha1"); shafunc = PyObject_GetAttrString(hashlib, "sha1");
Py_DECREF(hashlib); Py_DECREF(hashlib);