This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3640

state: fix usage of an unassigned variable
ClosedPublic

Authored by pulkit on May 21 2018, 2:56 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbdc4079ceb16: state: fix usage of an unassigned variable
Summary

The variable iv was used in earlier iterations of the patches and was dropped
since we made sure 'version' is always int. This usage of 'iv' should have been
replaced by 'version' in the original patch only.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 21 2018, 2:56 PM
Closed by commit rHGbdc4079ceb16: state: fix usage of an unassigned variable (authored by pulkit). · Explain WhyMay 22 2018, 8:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/state.py (2 lines)

Diff 8869

mercurial/state.py

we use third-party library cbor to serialize data to write in the file. we use third-party library cbor to serialize data to write in the file.
""" """
if not isinstance(version, int): if not isinstance(version, int):
raise error.ProgrammingError("version of state file should be" raise error.ProgrammingError("version of state file should be"
" an integer") " an integer")
with self._repo.vfs(self.fname, 'wb', atomictemp=True) as fp: with self._repo.vfs(self.fname, 'wb', atomictemp=True) as fp:
fp.write('%d\n' % iv) fp.write('%d\n' % version)
cbor.dump(self.opts, fp, canonical=True) cbor.dump(self.opts, fp, canonical=True)
def _read(self): def _read(self):
"""reads the state file and returns a dictionary which contain """reads the state file and returns a dictionary which contain
data in the same format as it was before storing""" data in the same format as it was before storing"""
with self._repo.vfs(self.fname, 'rb') as fp: with self._repo.vfs(self.fname, 'rb') as fp:
try: try:
version = int(fp.readline()) version = int(fp.readline())