This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3709

py3: replace unicode with type(u'')
AbandonedPublic

Authored by pulkit on Jun 10 2018, 6:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

unicode is not present on Python 3 and throws NameError because default strings
on py3 are unicodes.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Jun 10 2018, 6:33 AM
pulkit abandoned this revision.Jun 14 2018, 7:41 AM

Revision Contents
Changeset List

PathPackages
Mhgext/win32mbcs.py (2 lines)

Diff 9008

hgext/win32mbcs.py

# convert string arguments, call func, then convert back the # convert string arguments, call func, then convert back the
# return value. # return value.
return enc(func(*dec(args), **dec(kwds))) return enc(func(*dec(args), **dec(kwds)))
except UnicodeError: except UnicodeError:
raise error.Abort(_("[win32mbcs] filename conversion failed with" raise error.Abort(_("[win32mbcs] filename conversion failed with"
" %s encoding\n") % (_encoding)) " %s encoding\n") % (_encoding))
def wrapper(func, args, kwds): def wrapper(func, args, kwds):
return basewrapper(func, unicode, encode, decode, args, kwds) return basewrapper(func, type(u''), encode, decode, args, kwds)
def reversewrapper(func, args, kwds): def reversewrapper(func, args, kwds):
return basewrapper(func, str, decode, encode, args, kwds) return basewrapper(func, str, decode, encode, args, kwds)
def wrapperforlistdir(func, args, kwds): def wrapperforlistdir(func, args, kwds):
# Ensure 'path' argument ends with os.sep to avoids # Ensure 'path' argument ends with os.sep to avoids
# misinterpreting last 0x5c of MBCS 2nd byte as path separator. # misinterpreting last 0x5c of MBCS 2nd byte as path separator.