This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3713

revsets: define a none() revset
ClosedPublic

Authored by martinvonz on Jun 11 2018, 2:37 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf1d55ae2c5c8: revsets: define a none() revset
Summary

This can be useful for default values in corp-wide configuration
(e.g. for commits to hide, which defaults to none()), and perhaps in
scripts. I named it none() rather than empty() to match all().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jun 11 2018, 2:37 PM
Closed by commit rHGf1d55ae2c5c8: revsets: define a none() revset (authored by martinvonz). · Explain WhyJun 12 2018, 8:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (8 lines)
Mtests/test-revset2.t (3 lines)

Diff 9017

mercurial/revset.py

except error.WdirUnsupported: except error.WdirUnsupported:
rn = node.wdirrev rn = node.wdirrev
if rn is None: if rn is None:
return baseset() return baseset()
result = baseset([rn]) result = baseset([rn])
return result & subset return result & subset
@predicate('none()', safe=True)
def none(repo, subset, x):
"""No changesets.
"""
# i18n: "none" is a keyword
getargs(x, 0, 0, _("none takes no arguments"))
return baseset()
@predicate('obsolete()', safe=True) @predicate('obsolete()', safe=True)
def obsolete(repo, subset, x): def obsolete(repo, subset, x):
"""Mutable changeset with a newer version.""" """Mutable changeset with a newer version."""
# i18n: "obsolete" is a keyword # i18n: "obsolete" is a keyword
getargs(x, 0, 0, _("obsolete takes no arguments")) getargs(x, 0, 0, _("obsolete takes no arguments"))
obsoletes = obsmod.getrevs(repo, 'obsolete') obsoletes = obsmod.getrevs(repo, 'obsolete')
return subset & obsoletes return subset & obsoletes

tests/test-revset2.t

$ log '' $ log ''
hg: parse error: empty query hg: parse error: empty query
[255] [255]
$ log 'parents("")' $ log 'parents("")'
hg: parse error: empty string is not a valid revision hg: parse error: empty string is not a valid revision
[255] [255]
test empty revset
$ hg log 'none()'
we can use patterns when searching for tags we can use patterns when searching for tags
$ log 'tag("1..*")' $ log 'tag("1..*")'
abort: tag '1..*' does not exist! abort: tag '1..*' does not exist!
[255] [255]
$ log 'tag("re:1..*")' $ log 'tag("re:1..*")'
6 6
$ log 'tag("re:[0-9].[0-9]")' $ log 'tag("re:[0-9].[0-9]")'