This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3727

hgweb: insist http_status value is a sysstr
ClosedPublic

Authored by durin42 on Jun 12 2018, 9:09 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGaf0e88e64ede: hgweb: insist http_status value is a sysstr
Summary

My previous change was extremely confusing to figure out, because I
thought I was looking at a client-side problem. For the low cost of an
isinstance assert, we can make those errors not happen in the future.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jun 12 2018, 9:09 PM
Closed by commit rHGaf0e88e64ede: hgweb: insist http_status value is a sysstr (authored by durin42). · Explain WhyJun 13 2018, 8:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/server.py (1 line)

Diff 9048

mercurial/hgweb/server.py

if self._chunked: if self._chunked:
self.send_header(r'Transfer-Encoding', r'chunked') self.send_header(r'Transfer-Encoding', r'chunked')
else: else:
self.send_header(r'Connection', r'close') self.send_header(r'Connection', r'close')
self.end_headers() self.end_headers()
self.sent_headers = True self.sent_headers = True
def _start_response(self, http_status, headers, exc_info=None): def _start_response(self, http_status, headers, exc_info=None):
assert isinstance(http_status, str)
code, msg = http_status.split(None, 1) code, msg = http_status.split(None, 1)
code = int(code) code = int(code)
self.saved_status = http_status self.saved_status = http_status
bad_headers = ('connection', 'transfer-encoding') bad_headers = ('connection', 'transfer-encoding')
self.saved_headers = [h for h in headers self.saved_headers = [h for h in headers
if h[0].lower() not in bad_headers] if h[0].lower() not in bad_headers]
return self._write return self._write