This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3745

commit: use context manager for locks
ClosedPublic

Authored by martinvonz on Jun 14 2018, 7:32 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe218ed5ba484: commit: use context manager for locks
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jun 14 2018, 7:32 PM
Closed by commit rHGe218ed5ba484: commit: use context manager for locks (authored by martinvonz). · Explain WhyJun 15 2018, 8:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (7 lines)

Diff 9074

mercurial/commands.py

- commit all non-binary files:: - commit all non-binary files::
hg commit --exclude "set:binary()" hg commit --exclude "set:binary()"
- amend the current commit and set the date to now:: - amend the current commit and set the date to now::
hg commit --amend --date now hg commit --amend --date now
""" """
wlock = lock = None with repo.wlock(), repo.lock():
try:
wlock = repo.wlock()
lock = repo.lock()
return _docommit(ui, repo, *pats, **opts) return _docommit(ui, repo, *pats, **opts)
finally:
release(lock, wlock)
def _docommit(ui, repo, *pats, **opts): def _docommit(ui, repo, *pats, **opts):
if opts.get(r'interactive'): if opts.get(r'interactive'):
opts.pop(r'interactive') opts.pop(r'interactive')
ret = cmdutil.dorecord(ui, repo, commit, None, False, ret = cmdutil.dorecord(ui, repo, commit, None, False,
cmdutil.recordfilter, *pats, cmdutil.recordfilter, *pats,
**opts) **opts)
# ret can be 0 (no changes to record) or the value returned by # ret can be 0 (no changes to record) or the value returned by