( )⚙ D3777 debugbuilddag: use context manager for progress, locks, transaction

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3777

debugbuilddag: use context manager for progress, locks, transaction
ClosedPublic

Authored by martinvonz on Jun 18 2018, 3:04 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG0d7ec620faef: debugbuilddag: use context manager for progress, locks, transaction
Summary

I minor side-effect is that .hg/localtags is now written before the
transaction commits.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jun 18 2018, 3:04 AM
Closed by commit rHG0d7ec620faef: debugbuilddag: use context manager for progress, locks, transaction (authored by martinvonz). · Explain WhyJun 18 2018, 10:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/debugcommands.py (12 lines)

Diff 9148

mercurial/debugcommands.py

if mergeable_file: if mergeable_file:
linesperrev = 2 linesperrev = 2
# make a file with k lines per rev # make a file with k lines per rev
initialmergedlines = ['%d' % i for i in xrange(0, total * linesperrev)] initialmergedlines = ['%d' % i for i in xrange(0, total * linesperrev)]
initialmergedlines.append("") initialmergedlines.append("")
tags = [] tags = []
wlock = lock = tr = None
progress = ui.makeprogress(_('building'), unit=_('revisions'), progress = ui.makeprogress(_('building'), unit=_('revisions'),
total=total) total=total)
try: with progress, repo.wlock(), repo.lock(), repo.transaction("builddag"):
wlock = repo.wlock()
lock = repo.lock()
tr = repo.transaction("builddag")
at = -1 at = -1
atbranch = 'default' atbranch = 'default'
nodeids = [] nodeids = []
id = 0 id = 0
progress.update(id) progress.update(id)
for type, data in dagparser.parsedag(text): for type, data in dagparser.parsedag(text):
if type == 'n': if type == 'n':
ui.note(('node %s\n' % pycompat.bytestr(data))) ui.note(('node %s\n' % pycompat.bytestr(data)))
elif type == 'l': elif type == 'l':
id, name = data id, name = data
ui.note(('tag %s\n' % name)) ui.note(('tag %s\n' % name))
tags.append("%s %s\n" % (hex(repo.changelog.node(id)), name)) tags.append("%s %s\n" % (hex(repo.changelog.node(id)), name))
elif type == 'a': elif type == 'a':
ui.note(('branch %s\n' % data)) ui.note(('branch %s\n' % data))
atbranch = data atbranch = data
progress.update(id) progress.update(id)
tr.close()
if tags: if tags:
repo.vfs.write("localtags", "".join(tags)) repo.vfs.write("localtags", "".join(tags))
finally:
progress.complete()
release(tr, lock, wlock)
def _debugchangegroup(ui, gen, all=None, indent=0, **opts): def _debugchangegroup(ui, gen, all=None, indent=0, **opts):
indent_string = ' ' * indent indent_string = ' ' * indent
if all: if all:
ui.write(("%sformat: id, p1, p2, cset, delta base, len(delta)\n") ui.write(("%sformat: id, p1, p2, cset, delta base, len(delta)\n")
% indent_string) % indent_string)
def showchunks(named): def showchunks(named):