This is an archive of the discontinued Mercurial Phabricator instance.

progress: extract function for closing topic
ClosedPublic

Authored by martinvonz on Jun 20 2018, 1:44 AM.

Details

Summary

progress(None) had a completely different implementation from the
progress(<not None>) implementation. It very much feels like it should
be a separate method, so this patch makes it so. That also makes it
clear that only the topic parameter matters when closing a topic
(e.g. "total" does not matter).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jun 20 2018, 1:44 AM
This revision was automatically updated to reflect the committed changes.