This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3899

run-tests: add missing life-cycle methods on the example custom test result
ClosedPublic

Authored by lothiraldan on Jul 10 2018, 2:25 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf4a214300957: run-tests: add missing life-cycle methods on the example custom test result
Summary

A previous commit introduced onStart and onEnd methods on test result but
the one used in tests lacked those two methods. Fix it and add some output to
be sure they are called.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Jul 10 2018, 2:25 AM
Closed by commit rHGf4a214300957: run-tests: add missing life-cycle methods on the example custom test result (authored by lothiraldan). · Explain WhyJul 10 2018, 9:06 AM
This revision was automatically updated to reflect the committed changes.
lothiraldan updated this revision to Diff 9498.Jul 10 2018, 9:11 AM

Revision Contents
Changeset List

PathPackages
Mtests/basic_test_result.py (8 lines)
Mtests/test-run-tests.t (2 lines)

Diff 9495

tests/basic_test_result.py

from __future__ import print_function from __future__ import absolute_import, print_function
import unittest import unittest
class TestResult(unittest._TextTestResult): class TestResult(unittest._TextTestResult):
def __init__(self, options, *args, **kwargs): def __init__(self, options, *args, **kwargs):
super(TestResult, self).__init__(*args, **kwargs) super(TestResult, self).__init__(*args, **kwargs)
self._options = options self._options = options
# Polyfill. # Polyfill.
def addSkip(self, test, reason): def addSkip(self, test, reason):
print("SKIP!", test, reason) print("SKIP!", test, reason)
def addIgnore(self, test, reason): def addIgnore(self, test, reason):
print("IGNORE!", test, reason) print("IGNORE!", test, reason)
def onStart(self, test):
print("ON_START!", test)
def onEnd(self):
print("ON_END!")
def addOutputMismatch(self, test, ret, got, expected): def addOutputMismatch(self, test, ret, got, expected):
return False return False
def stopTest(self, test, interrupted=False): def stopTest(self, test, interrupted=False):
super(TestResult, self).stopTest(test) super(TestResult, self).stopTest(test)

tests/test-run-tests.t

$LOCALIP (glob) $LOCALIP (glob)
Add support for external test formatter Add support for external test formatter
======================================= =======================================
$ CUSTOM_TEST_RESULT=basic_test_result $PYTHON $TESTDIR/run-tests.py --with-hg=`which hg` "$@" test-success.t test-failure.t $ CUSTOM_TEST_RESULT=basic_test_result $PYTHON $TESTDIR/run-tests.py --with-hg=`which hg` "$@" test-success.t test-failure.t
# Ran 2 tests, 0 skipped, 0 failed. # Ran 2 tests, 0 skipped, 0 failed.
ON_START! <__main__.TestSuite tests=[<__main__.TTest testMethod=test-failure.t>, <__main__.TTest testMethod=test-success.t>]>
FAILURE! test-failure.t output changed FAILURE! test-failure.t output changed
SUCCESS! test-success.t SUCCESS! test-success.t
ON_END!
Test reusability for third party tools Test reusability for third party tools
====================================== ======================================
$ mkdir "$TESTTMP"/anothertests $ mkdir "$TESTTMP"/anothertests
$ cd "$TESTTMP"/anothertests $ cd "$TESTTMP"/anothertests
test that `run-tests.py` can execute hghave, even if it runs not in test that `run-tests.py` can execute hghave, even if it runs not in