( )⚙ D3964 macosx: fixing macOS version generation after db9d1dd01bf0

This is an archive of the discontinued Mercurial Phabricator instance.

macosx: fixing macOS version generation after db9d1dd01bf0
ClosedPublic

Authored by rdamazio on Jul 18 2018, 9:45 PM.

Details

Summary

With the Python3 change, the string is now something like
version = b'4.6.2+848-88be288e8ac1'
where it was previously just:
version = '4.6.2+848-88be288e8ac1'

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

rdamazio created this revision.Jul 18 2018, 9:45 PM
rdamazio retitled this revision from macosx: fixing macOS version generation after dbbe45ae5ad1 to macosx: fixing macOS version generation after db9d1dd01bf0.Jul 18 2018, 9:48 PM

Er, actually, let me fix this again - this unbreaks the build but generates packages like 'Mercurial-"4.6.2+674-f83600efa1ca-macosx10.13.dmg'.

This is python code, why is it parsing the version file instead of importing it?

Hmm and nevermind, the weird package name doesn't reproduce on a vanilla hg build, you can go ahead and review.

This is python code, why is it parsing the version file instead of importing it?

Great question, no idea :) I took the minimal fix approach to reduce the change of further breaking it.

This revision was automatically updated to reflect the committed changes.