This is an archive of the discontinued Mercurial Phabricator instance.

Differential D407

remotefilelog: fix flaky bgprefetch test
ClosedPublic

Authored by ms2316 on Aug 15 2017, 6:05 AM.
Tags
None
Subscribers
None

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGXab8836fee021: remotefilelog: fix flaky bgprefetch test
Summary

The test failed due to a race condition. Now the failing part of the test output is optional.

Test Plan

Ensure that unit tests do not fail

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ms2316 created this revision.Aug 15 2017, 6:05 AM
ms2316 updated this revision to Diff 926.Aug 15 2017, 6:11 AM

Added empty line

ryanmce accepted this revision.Aug 15 2017, 6:47 AM
This revision is now accepted and ready to land.Aug 15 2017, 6:47 AM
Closed by commit rFBHGXab8836fee021: remotefilelog: fix flaky bgprefetch test (authored by ms2316). · Explain WhyAug 16 2017, 11:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 989

tests/test-remotefilelog-bgprefetch.t

69a1b6752270 000000000000 2 69a1b6752270 000000000000 2
# Check that foregound prefetch with no arguments blocks until background prefetches finish # Check that foregound prefetch with no arguments blocks until background prefetches finish
$ hg up -r 3 $ hg up -r 3
2 files updated, 0 files merged, 0 files removed, 0 files unresolved 2 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ clearcache $ clearcache
$ hg prefetch --repack $ hg prefetch --repack
waiting for lock on prefetching in $TESTTMP/shallow held by process * on host * (glob) waiting for lock on prefetching in $TESTTMP/shallow held by process * on host * (glob) (?)
got lock after 1 seconds got lock after * seconds (glob) (?)
(running background incremental repack) (running background incremental repack)
* files fetched over 1 fetches - (* misses, 0.00% hit ratio) over *s (glob) (?)
$ sleep 0.5 $ sleep 0.5
$ hg debugwaitonrepack >/dev/null 2>%1 $ hg debugwaitonrepack >/dev/null 2>%1
$ find $CACHEDIR -type f | sort $ find $CACHEDIR -type f | sort
$TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histidx $TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histidx
$TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histpack $TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histpack
$TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.dataidx $TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.dataidx
$TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.datapack $TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.datapack