| hg-reviewers |
Looking at what it is used for, it feels like there is a better
way to implement all this. So recording a TODO to track that.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/changegroup.py (11 lines) |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg | ||
| Closed | indygreg |
| self._repo = repo | self._repo = repo | ||||
| if self._repo.ui.verbose and not self._repo.ui.debugflag: | if self._repo.ui.verbose and not self._repo.ui.debugflag: | ||||
| self._verbosenote = self._repo.ui.note | self._verbosenote = self._repo.ui.note | ||||
| else: | else: | ||||
| self._verbosenote = lambda s: None | self._verbosenote = lambda s: None | ||||
| # TODO the functionality keyed off of this should probably be | |||||
| # controlled via arguments to group() that influence behavior. | |||||
| self._changelogdone = False | |||||
| def _close(self): | def _close(self): | ||||
| # Ellipses serving mode. | # Ellipses serving mode. | ||||
| getattr(self, '_clrev_to_localrev', {}).clear() | getattr(self, '_clrev_to_localrev', {}).clear() | ||||
| if getattr(self, '_next_clrev_to_localrev', {}): | if getattr(self, '_next_clrev_to_localrev', {}): | ||||
| self._clrev_to_localrev = self._next_clrev_to_localrev | self._clrev_to_localrev = self._next_clrev_to_localrev | ||||
| del self._next_clrev_to_localrev | del self._next_clrev_to_localrev | ||||
| self._changelog_done = True | self._changelogdone = True | ||||
| return closechunk() | return closechunk() | ||||
| def _fileheader(self, fname): | def _fileheader(self, fname): | ||||
| return chunkheader(len(fname)) + fname | return chunkheader(len(fname)) + fname | ||||
| # Extracted both for clarity and for overriding in extensions. | # Extracted both for clarity and for overriding in extensions. | ||||
| def _sortgroup(self, store, nodelist, lookup): | def _sortgroup(self, store, nodelist, lookup): | ||||
| linknode=linknode, | linknode=linknode, | ||||
| flags=store.flags(rev), | flags=store.flags(rev), | ||||
| deltachunks=(prefix, delta), | deltachunks=(prefix, delta), | ||||
| ) | ) | ||||
| def _revisiondeltanarrow(self, store, rev, prev, linknode): | def _revisiondeltanarrow(self, store, rev, prev, linknode): | ||||
| # build up some mapping information that's useful later. See | # build up some mapping information that's useful later. See | ||||
| # the local() nested function below. | # the local() nested function below. | ||||
| if not self._changelog_done: | if not self._changelogdone: | ||||
| self._clnode_to_rev[linknode] = rev | self._clnode_to_rev[linknode] = rev | ||||
| linkrev = rev | linkrev = rev | ||||
| self._clrev_to_localrev[linkrev] = rev | self._clrev_to_localrev[linkrev] = rev | ||||
| else: | else: | ||||
| linkrev = self._clnode_to_rev[linknode] | linkrev = self._clnode_to_rev[linknode] | ||||
| self._clrev_to_localrev[linkrev] = rev | self._clrev_to_localrev[linkrev] = rev | ||||
| # This is a node to send in full, because the changeset it | # This is a node to send in full, because the changeset it | ||||
| non-changelog revlogs, we need to turn those numbers into | non-changelog revlogs, we need to turn those numbers into | ||||
| something local. This does that for us, and during the | something local. This does that for us, and during the | ||||
| changelog sending phase will also expand the stored | changelog sending phase will also expand the stored | ||||
| mappings as needed. | mappings as needed. | ||||
| """ | """ | ||||
| if clrev == nullrev: | if clrev == nullrev: | ||||
| return nullrev | return nullrev | ||||
| if not self._changelog_done: | if not self._changelogdone: | ||||
| # If we're doing the changelog, it's possible that we | # If we're doing the changelog, it's possible that we | ||||
| # have a parent that is already on the client, and we | # have a parent that is already on the client, and we | ||||
| # need to store some extra mapping information so that | # need to store some extra mapping information so that | ||||
| # our contained ellipsis nodes will be able to resolve | # our contained ellipsis nodes will be able to resolve | ||||
| # their parents. | # their parents. | ||||
| if clrev not in self._clrev_to_localrev: | if clrev not in self._clrev_to_localrev: | ||||
| clnode = store.node(clrev) | clnode = store.node(clrev) | ||||
| self._clnode_to_rev[clnode] = clrev | self._clnode_to_rev[clnode] = clrev | ||||
| packer._precomputed_ellipsis = ellipsisroots | packer._precomputed_ellipsis = ellipsisroots | ||||
| # Maps CL revs to per-revlog revisions. Cleared in close() at | # Maps CL revs to per-revlog revisions. Cleared in close() at | ||||
| # the end of each group. | # the end of each group. | ||||
| packer._clrev_to_localrev = {} | packer._clrev_to_localrev = {} | ||||
| packer._next_clrev_to_localrev = {} | packer._next_clrev_to_localrev = {} | ||||
| # Maps changelog nodes to changelog revs. Filled in once | # Maps changelog nodes to changelog revs. Filled in once | ||||
| # during changelog stage and then left unmodified. | # during changelog stage and then left unmodified. | ||||
| packer._clnode_to_rev = {} | packer._clnode_to_rev = {} | ||||
| packer._changelog_done = False | |||||
| return packer.generate(common, visitnodes, False, source) | return packer.generate(common, visitnodes, False, source) | ||||