This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4097

narrow: remove a repo file-cache invalidation
ClosedPublic

Authored by martinvonz on Aug 3 2018, 5:23 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHGae2962bb56a3: narrow: remove a repo file-cache invalidation

Summary

It's unclear why this was needed. All tests pass without it. I asked
Kyle Lippincott (who added the check) and he also doesn't remember
what it was for.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 3 2018, 5:23 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptAug 3 2018, 5:23 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

martinvonz added a child revision: D4098: narrow: drop checkambig=True when restoring backup.Aug 3 2018, 5:24 PM

martinvonz updated this revision to Diff 9872.Aug 3 2018, 8:12 PM

Closed by commit rHGae2962bb56a3: narrow: remove a repo file-cache invalidation (authored by martinvonz). · Explain WhyAug 5 2018, 9:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/narrowspec.py (3 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	9859		Aug 3 2018, 5:23 PM	★	★
Diff 2	9872		Aug 3 2018, 8:12 PM	★	★
Diff 3	9932	rHGae2962bb56a340e4bc66292ee4daafc0650f128a	Aug 2 2018, 5:30 PM	★	★

Status	Author	Revision
Closed	martinvonz	D4099 narrow: move .hg/narrowspec to .hg/store/narrowspec (BC)
Closed	martinvonz	D4098 narrow: drop checkambig=True when restoring backup
Closed	martinvonz	D4097 narrow: remove a repo file-cache invalidation
Closed	martinvonz	D4096 narrow: call narrowspec.{save,restore,clear}backup directly
Closed	martinvonz	D4095 narrow: extract part of narrowspec backup to core
Closed	martinvonz	D4094 narrow: move requirement constant from changegroup to repository
Closed	martinvonz	D4093 tests: avoid unnecessarily looking inside .hg/ in test-narrow*

Diff 9932

mercurial/narrowspec.py


	def load(repo):			def load(repo):
	try:			try:
	spec = repo.vfs.read(FILENAME)			spec = repo.vfs.read(FILENAME)
	except IOError as e:			except IOError as e:
	# Treat "narrowspec does not exist" the same as "narrowspec file exists			# Treat "narrowspec does not exist" the same as "narrowspec file exists
	# and is empty".			# and is empty".
	if e.errno == errno.ENOENT:			if e.errno == errno.ENOENT:
	# Without this the next call to load will use the cached
	# non-existence of the file, which can cause some odd issues.
	repo.invalidate(clearfilecache=True)
	return set(), set()			return set(), set()
	raise			raise
	# maybe we should care about the profiles returned too			# maybe we should care about the profiles returned too
	includepats, excludepats, profiles = sparse.parseconfig(repo.ui, spec,			includepats, excludepats, profiles = sparse.parseconfig(repo.ui, spec,
	'narrow')			'narrow')
	if profiles:			if profiles:
	raise error.Abort(_("including other spec files using '%include' is not"			raise error.Abort(_("including other spec files using '%include' is not"
	" suported in narrowspec"))			" suported in narrowspec"))