This is an archive of the discontinued Mercurial Phabricator instance.

undo: informative output
ClosedPublic

Authored by felixmerk on Aug 15 2017, 9:06 PM.
Tags
None
Subscribers

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGXfb0eda1a7127: undo: informative output
Summary

Instead of the _showstats output from hg.py, we now output the args and time of
the mercurial command we are undoing.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

felixmerk created this revision.Aug 15 2017, 9:06 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2017, 9:06 PM
quark requested changes to this revision.Aug 15 2017, 9:51 PM
quark added a subscriber: quark.
quark added inline comments.
hgext3rd/undo.py
762

This might swallow other important messages. There is a better way to silent "update" output.

793–795

hg.clean seems cleaner:

hg.clean(repo, workingcopyparent, show_stats=False)

Since we have cmdutil.bailifchanged() checked before, it should not drop uncommitted changes.

846

Maybe say something here, like:

undone to TIME, just after COMMAND

We probably want to avoid the detailed output if -b is used.

This revision now requires changes to proceed.Aug 15 2017, 9:51 PM
felixmerk edited edge metadata.Aug 16 2017, 4:38 PM
felixmerk updated this revision to Diff 1014.
quark accepted this revision.Aug 16 2017, 5:24 PM
This revision is now accepted and ready to land.Aug 16 2017, 5:24 PM

With this change I'm leaving in the -b as it now makes sense. The command that is posted as output is the (first) one of the commands that affected that branch and were undone.

quark added a comment.Aug 18 2017, 2:47 PM

The "before" change is smart. I like it!

This revision was automatically updated to reflect the committed changes.