This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4145

fix: pull out flag definitions to make them re-usable from extensions
ClosedPublic

Authored by hooper on Aug 6 2018, 7:52 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb0c591950e51: fix: pull out flag definitions to make them re-usable from extensions
Summary

This makes it cleaner to implement fix-related commands with additional
functionality while sharing some flags with the core implementation.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (19 lines)

Diff 10020

hgext/fix.py

for key in FIXER_ATTRS: for key in FIXER_ATTRS:
configitem('fix', '.*(:%s)?' % key, default=None, generic=True) configitem('fix', '.*(:%s)?' % key, default=None, generic=True)
# A good default size allows most source code files to be fixed, but avoids # A good default size allows most source code files to be fixed, but avoids
# letting fixer tools choke on huge inputs, which could be surprising to the # letting fixer tools choke on huge inputs, which could be surprising to the
# user. # user.
configitem('fix', 'maxfilesize', default='2MB') configitem('fix', 'maxfilesize', default='2MB')
@command('fix', allopt = ('', 'all', False, _('fix all non-public non-obsolete revisions'))
[('', 'all', False, _('fix all non-public non-obsolete revisions')), baseopt = ('', 'base', [], _('revisions to diff against (overrides automatic '
('', 'base', [], _('revisions to diff against (overrides automatic '
'selection, and applies to every revision being ' 'selection, and applies to every revision being '
'fixed)'), _('REV')), 'fixed)'), _('REV'))
('r', 'rev', [], _('revisions to fix'), _('REV')), revopt = ('r', 'rev', [], _('revisions to fix'), _('REV'))
('w', 'working-dir', False, _('fix the working directory')), wdiropt = ('w', 'working-dir', False, _('fix the working directory'))
('', 'whole', False, _('always fix every line of a file'))], wholeopt = ('', 'whole', False, _('always fix every line of a file'))
_('[OPTION]... [FILE]...')) usage = _('[OPTION]... [FILE]...')
@command('fix', [allopt, baseopt, revopt, wdiropt, wholeopt], usage)
def fix(ui, repo, *pats, **opts): def fix(ui, repo, *pats, **opts):
"""rewrite file content in changesets or working directory """rewrite file content in changesets or working directory
Runs any configured tools to fix the content of files. Only affects files Runs any configured tools to fix the content of files. Only affects files
with changes, unless file arguments are provided. Only affects changed lines with changes, unless file arguments are provided. Only affects changed lines
of files, unless the --whole flag is used. Some tools may always affect the of files, unless the --whole flag is used. Some tools may always affect the
whole file regardless of --whole. whole file regardless of --whole.