This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D4234 tests: allow for a bonus newline in base64'd email payload
Closed	durin42	D4233 mail: be more cautious about bytes vs str for py3 compat
Closed	durin42	D4232 patchbomb: use native strings when determining attachment disposition
Closed	durin42	D4231 mail: always fall back to iso-8859-1 if us-ascii won't work (BC)
Closed	durin42	D4230 tests: put some Python 3 polish on inline Python invocations
Closed	durin42	D4229 patchbomb: don't unintentionally duplicate headers
Closed	durin42	D4228 patchbomb: use sysstrs when describing content-type
Closed	durin42	D4223 patchbomb: use native strs for email header keys and values
Closed	durin42	D4222 patchbomb: use email.encoders instead of email.Encoders
Closed	durin42	D4221 mail: properly handle email addresses typically being unicodes
Closed	durin42	D4220 tests: fix Python3 issues in Python one-liners in test-patchbomb.t
Closed	durin42	D4219 dummysmtpd: accept additional kwargs from stdlib smtpd
Closed	durin42	D4218 mail: fix debug print, which appears to have been broken for a long time
Closed	durin42	D3957 patchbomb: python 3 really wants those email addresses in unicode
Closed	durin42	D3956 mail: stop using the smtplib.SSLFakeFile and use socket.socket.makefile
Closed	durin42	D3955 mail: modernize check for Python-with-TLS
Closed	durin42	D3954 mail: cope with Py3 unicode antics on email addresses
Closed	durin42	D3953 mail: fix _encode to be more correct on Python 3
Closed	durin42	D3951 patchbomb: work around email module really wanting to write unicode data

Diff 10226

hgext/patchbomb.py

	if t.endswith('.patch') or t.endswith('.diff')]			if t.endswith('.patch') or t.endswith('.diff')]
	if patchtags:			if patchtags:
	patchname = patchtags[0]			patchname = patchtags[0]
	elif total > 1:			elif total > 1:
	patchname = cmdutil.makefilename(repo[node], '%b-%n.patch',			patchname = cmdutil.makefilename(repo[node], '%b-%n.patch',
	seqno=idx, total=total)			seqno=idx, total=total)
	else:			else:
	patchname = cmdutil.makefilename(repo[node], '%b.patch')			patchname = cmdutil.makefilename(repo[node], '%b.patch')
	disposition = 'inline'			disposition = r'inline'
	if opts.get('attach'):			if opts.get('attach'):
	disposition = 'attachment'			disposition = r'attachment'
	p['Content-Disposition'] = disposition + '; filename=' + patchname			p[r'Content-Disposition'] = (
				disposition + r'; filename=' + encoding.strfromlocal(patchname))
	msg.attach(p)			msg.attach(p)
	else:			else:
	msg = mail.mimetextpatch(body, display=opts.get('test'))			msg = mail.mimetextpatch(body, display=opts.get('test'))

	prefix = _formatprefix(ui, repo, rev, opts.get('flag'), idx, total,			prefix = _formatprefix(ui, repo, rev, opts.get('flag'), idx, total,
	numbered)			numbered)
	subj = desc[0].strip().rstrip('. ')			subj = desc[0].strip().rstrip('. ')
	if not numbered:			if not numbered:

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	10226		Aug 9 2018, 10:07 PM	★	★
Diff 2	10264	rHG2161faf0d24bbb0d4efc9a0aec0bfa1bd8aff8bd	Aug 9 2018, 9:57 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

patchbomb: use native strings when determining attachment dispositionClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10226

hgext/patchbomb.py

patchbomb: use native strings when determining attachment disposition
ClosedPublic

Revision Contents
Changeset List