This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4301

tests: add a directory 'knownfailures' to check in known failures
Needs RevisionPublic

Authored by pulkit on Aug 16 2018, 10:59 AM.

Details

Reviewers
durin42
baymax
Group Reviewers
hg-reviewers
Summary

There are some things which everyone of us stumble upon and found out that this
does not work. Sometimes, we hg developers know that these things does not works
because of experience. But this does not scale well when we have a new developer
or maybe a user who wants to see what does not work and is interested in fixing
that.

Checking in the tests about the things which don't work will help others to
reproduce these and also helps in fixing because of functionalities
./run-tests.py provides.

IIRC we had this thought in one of the previous sprints also to checkin some of
the known failures.

I am starting with checking in a basic test failure. But I plan to check in
more narrow related failures which we have found.

Unable to find easily what exactly broken with merges and narrow made me to
implement this idea so that we won't have similar problem in future.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Aug 16 2018, 10:59 AM
pulkit added a comment.Aug 16 2018, 11:07 AM

I also think that the 'knowfailures' can serve as a good place for new contributors.
I don't want to check-in all the failures and leave them unfixed. It's like I don't know which one I will be able to fix and I have a reproduction which can help others.

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM

Revision Contents
Changeset List

PathPackages
Ptests/knownfailures/test-narrow-widen.t (4 lines)
Copied from tests/test-narrow-widen.t
Ptests/test-narrow-widen.t
Copied to tests/knownfailures/test-narrow-widen.t

Diff 10391

tests/knownfailures/test-narrow-widen.t

  • This file was copied from tests/test-narrow-widen.t.
#testcases flat tree #testcases flat tree
$ . "$TESTDIR/narrow-library.sh" $ . "$TESTDIR/narrow-library.sh"
#if tree #if tree
$ cat << EOF >> $HGRCPATH $ cat << EOF >> $HGRCPATH
> [experimental] > [experimental]
> treemanifest = 1 > treemanifest = 1
> EOF > EOF
#endif #endif
$ hg init master $ hg init master
$ cd master $ cd master
$ cat >> .hg/hgrc <<EOF
> [narrow]
> serveellipses=True
> EOF
$ mkdir inside $ mkdir inside
$ echo 'inside' > inside/f $ echo 'inside' > inside/f
$ hg add inside/f $ hg add inside/f
$ hg commit -m 'add inside' $ hg commit -m 'add inside'
$ mkdir widest $ mkdir widest
$ echo 'widest' > widest/f $ echo 'widest' > widest/f

tests/test-narrow-widen.t

  • This file was copied to tests/knownfailures/test-narrow-widen.t.