This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4338

beautifygraph: don't warn about busted terminal if HGPLAIN is set
ClosedPublic

Authored by durin42 on Aug 20 2018, 4:34 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG362cb82385ea: beautifygraph: don't warn about busted terminal if HGPLAIN is set
Summary

This was breaking some automation for users that discovered the
extension and turned it on.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Aug 20 2018, 4:34 PM
martinvonz accepted this revision.Aug 20 2018, 6:25 PM
martinvonz added a subscriber: martinvonz.

Queued for stable, thanks.

This revision is now accepted and ready to land.Aug 20 2018, 6:25 PM
Closed by commit rHG362cb82385ea: beautifygraph: don't warn about busted terminal if HGPLAIN is set (authored by durin42). · Explain WhyAug 20 2018, 6:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/beautifygraph.py (6 lines)

Diff 10479

hgext/beautifygraph.py

return node return node
def outputprettygraph(orig, ui, graph, *args, **kwargs): def outputprettygraph(orig, ui, graph, *args, **kwargs):
(edges, text) = zip(*graph) (edges, text) = zip(*graph)
graph = zip([convertedges(e) for e in edges], text) graph = zip([convertedges(e) for e in edges], text)
return orig(ui, graph, *args, **kwargs) return orig(ui, graph, *args, **kwargs)
def extsetup(ui): def extsetup(ui):
if ui.plain('graph'):
return
if encoding.encoding != 'UTF-8': if encoding.encoding != 'UTF-8':
ui.warn(_('beautifygraph: unsupported encoding, UTF-8 required\n')) ui.warn(_('beautifygraph: unsupported encoding, UTF-8 required\n'))
return return
if 'A' in encoding._wide: if 'A' in encoding._wide:
ui.warn(_('beautifygraph: unsupported terminal settings, ' ui.warn(_('beautifygraph: unsupported terminal settings, '
'monospace narrow text required\n')) 'monospace narrow text required\n'))
return return
if ui.plain('graph'):
return
extensions.wrapfunction(graphmod, 'outputgraph', outputprettygraph) extensions.wrapfunction(graphmod, 'outputgraph', outputprettygraph)
extensions.wrapfunction(templatekw, 'getgraphnode', getprettygraphnode) extensions.wrapfunction(templatekw, 'getgraphnode', getprettygraphnode)