This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4339

index: fix a comment about overflow-checking
ClosedPublic

Authored by martinvonz on Aug 20 2018, 6:58 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGfcaffbd7e635: index: fix a comment about overflow-checking
Summary

There's no "argument-checking" done in this method. This was a bad
copy paste.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Aug 20 2018, 6:58 PM
Closed by commit rHGfcaffbd7e635: index: fix a comment about overflow-checking (authored by martinvonz). · Explain WhyAug 21 2018, 8:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (2 lines)

Diff 10484

mercurial/cext/revlog.c

static int nt_delete_node(nodetree *self, const char *node) static int nt_delete_node(nodetree *self, const char *node)
{ {
/* rev==-2 happens to get encoded as 0, which is interpreted as not set */ /* rev==-2 happens to get encoded as 0, which is interpreted as not set */
return nt_insert(self, node, -2); return nt_insert(self, node, -2);
} }
static int nt_init(nodetree *self, indexObject *index, unsigned capacity) static int nt_init(nodetree *self, indexObject *index, unsigned capacity)
{ {
/* Initialize before argument-checking to avoid nt_dealloc() crash. */ /* Initialize before overflow-checking to avoid nt_dealloc() crash. */
self->nodes = NULL; self->nodes = NULL;
self->index = index; self->index = index;
Py_INCREF(index); Py_INCREF(index);
/* The input capacity is in terms of revisions, while the field is in /* The input capacity is in terms of revisions, while the field is in
* terms of nodetree nodes. */ * terms of nodetree nodes. */
self->capacity = (capacity < 4 ? 4 : capacity / 2); self->capacity = (capacity < 4 ? 4 : capacity / 2);
self->depth = 0; self->depth = 0;