( )⚙ D4356 tests: use inline Python for revlog test

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4356

tests: use inline Python for revlog test
ClosedPublic

Authored by indygreg on Aug 22 2018, 4:58 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGda459d426c20: tests: use inline Python for revlog test
Summary

hg debugdata will soon stop accepting the raw path to a revlog file.
Adjust a test accordingly.

The changed test is for a security bug. So this should be reviewed
with scrutiny.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 22 2018, 4:58 PM
Closed by commit rHGda459d426c20: tests: use inline Python for revlog test (authored by indygreg). · Explain WhyAug 25 2018, 10:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-revlog.t (9 lines)

Diff 10568

tests/test-revlog.t

... b"""eJxjYGZgZIAAYQYGxhgom+k/FMx8YKx9ZUaKSOyqo4cnuKb8mbqHV5cBCVTMWb1Cwqkhe4Gsg9AD ... b"""eJxjYGZgZIAAYQYGxhgom+k/FMx8YKx9ZUaKSOyqo4cnuKb8mbqHV5cBCVTMWb1Cwqkhe4Gsg9AD
... Joa3dYtcYYYBAQ8Qr4OqZAYRICPTSr5WKd/42rV36d+8/VmrNpv7NP1jQAXrQE4BqQUARngwVA==""" ... Joa3dYtcYYYBAQ8Qr4OqZAYRICPTSr5WKd/42rV36d+8/VmrNpv7NP1jQAXrQE4BqQUARngwVA=="""
... .decode("base64").decode("zlib")) ... .decode("base64").decode("zlib"))
$ hg debugindex a.i $ hg debugindex a.i
rev linkrev nodeid p1 p2 rev linkrev nodeid p1 p2
0 2 99e0332bd498 000000000000 000000000000 0 2 99e0332bd498 000000000000 000000000000
1 3 6674f57a23d8 99e0332bd498 000000000000 1 3 6674f57a23d8 99e0332bd498 000000000000
$ hg debugdata a.i 1 2>&1 | egrep 'Error:.*decoded'
(mercurial\.\w+\.mpatch\.)?mpatchError: patch cannot be decoded (re) >>> from mercurial import revlog, vfs
>>> tvfs = vfs.vfs(b'.')
>>> tvfs.options = {b'revlogv1': True}
>>> rl = revlog.revlog(tvfs, b'a.i')
>>> rl.revision(1)
mpatchError('patch cannot be decoded',)