This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4359

filelog: remove proxies to revlog
ClosedPublic

Authored by indygreg on Aug 22 2018, 4:58 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG71575a1e197e: filelog: remove proxies to revlog
Summary

These proxy attributes and methods were added to facilitate various
debug* and perf* commands. Now that cmdutil.openrevlog() returns
an actual revlog, we no longer need these on the filelog class.

There's probably a few other attributes that could be removed. But
this feels like a worthy start.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 22 2018, 4:58 PM
Closed by commit rHG71575a1e197e: filelog: remove proxies to revlog (authored by indygreg). · Explain WhyAug 25 2018, 10:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/filelog.py (41 lines)

Diff 10571

mercurial/filelog.py

@property @property
def datafile(self): def datafile(self):
return self._revlog.datafile return self._revlog.datafile
@property @property
def opener(self): def opener(self):
return self._revlog.opener return self._revlog.opener
@property
def _lazydeltabase(self):
return self._revlog._lazydeltabase
@_lazydeltabase.setter
def _lazydeltabase(self, value):
self._revlog._lazydeltabase = value
@property
def _deltabothparents(self):
return self._revlog._deltabothparents
@_deltabothparents.setter
def _deltabothparents(self, value):
self._revlog._deltabothparents = value
@property
def _inline(self):
return self._revlog._inline
@property
def _withsparseread(self):
return getattr(self._revlog, '_withsparseread', False)
@property
def _srmingapsize(self):
return self._revlog._srmingapsize
@property
def _srdensitythreshold(self):
return self._revlog._srdensitythreshold
def _deltachain(self, rev, stoprev=None):
return self._revlog._deltachain(rev, stoprev)
def chainbase(self, rev):
return self._revlog.chainbase(rev)
def chainlen(self, rev):
return self._revlog.chainlen(rev)
def clone(self, tr, destrevlog, **kwargs): def clone(self, tr, destrevlog, **kwargs):
if not isinstance(destrevlog, filelog): if not isinstance(destrevlog, filelog):
raise error.ProgrammingError('expected filelog to clone()') raise error.ProgrammingError('expected filelog to clone()')
return self._revlog.clone(tr, destrevlog._revlog, **kwargs) return self._revlog.clone(tr, destrevlog._revlog, **kwargs)
def start(self, rev): def start(self, rev):
return self._revlog.start(rev) return self._revlog.start(rev)