Page MenuHomePhabricator

perftweaks: don't crash if the rebase dest is None
ClosedPublic

Authored by mitrandir on Aug 17 2017, 3:13 PM.

Details

Summary

This happens in case of "pull --rebase" if the source is ancestor of destination

Test Plan

see the new test, it's making hg crash without this change

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mitrandir created this revision.Aug 17 2017, 3:13 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2017, 3:13 PM
ryanmce accepted this revision.Aug 17 2017, 3:14 PM
ryanmce added a subscriber: ryanmce.

Thanks!

This revision is now accepted and ready to land.Aug 17 2017, 3:14 PM
simonfar accepted this revision.Aug 17 2017, 3:14 PM
This revision was automatically updated to reflect the committed changes.