This is an archive of the discontinued Mercurial Phabricator instance.

Differential D439

undo: performance improvement attempt
ClosedPublic

Authored by felixmerk on Aug 17 2017, 6:41 PM.
Tags
None
Subscribers
quark

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGXf547c4194f2e: undo: performance improvement attempt
Summary

Undo -p is really slow on certain large repos. This caches 'olddraft()' by
using the revlog nodes. Since revlogs are immutable this should be really safe
and could hopefully dramatically improve not only hg undo -p performance, but
performance of all undo commands.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

felixmerk created this revision.Aug 17 2017, 6:41 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2017, 6:41 PM
quark accepted this revision.Aug 17 2017, 7:31 PM
quark added a subscriber: quark.

Let's try it!

This revision is now accepted and ready to land.Aug 17 2017, 7:31 PM
Closed by commit rFBHGXf547c4194f2e: undo: performance improvement attempt (authored by felixmerk). · Explain WhyAug 18 2017, 6:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/undo.py (23 lines)

Diff 1062

hgext3rd/undo.py

content = rawcontent content = rawcontent
fm.startitem() fm.startitem()
fm.write('content', '%s', header + content) fm.write('content', '%s', header + content)
fm.end() fm.end()
# Revset logic # Revset logic
def _getolddrafts(repo, reverseindex): def _getolddrafts(repo, reverseindex):
# convert reverseindex to node
# this makes cacheing guaranteed correct
# bc immutable history
nodedict = _readindex(repo, reverseindex) nodedict = _readindex(repo, reverseindex)
olddraftheads = _readnode(repo, "draftheads.i", nodedict["draftheads"]) return _cachedgetolddrafts(repo, nodedict["draftheads"])
def _cachedgetolddrafts(repo, node):
if not util.safehasattr(repo, '_undoolddraftcache'):
repo._undoolddraftcache = {}
cache = repo._undoolddraftcache
if node not in cache:
olddraftheads = _readnode(repo, "draftheads.i", node)
oldheadslist = olddraftheads.split("\n") oldheadslist = olddraftheads.split("\n")
oldlogrevstring = revsetlang.formatspec('draft() & ancestors(%ls)', oldlogrevstring = revsetlang.formatspec('draft() & ancestors(%ls)',
oldheadslist) oldheadslist)
urepo = repo.unfiltered() urepo = repo.unfiltered()
return urepo.revs(oldlogrevstring) cache[node] = smartset.baseset(urepo.revs(oldlogrevstring))
return cache[node]
revsetpredicate = registrar.revsetpredicate() revsetpredicate = registrar.revsetpredicate()
@revsetpredicate('olddraft') @revsetpredicate('olddraft')
def _olddraft(repo, subset, x): def _olddraft(repo, subset, x):
"""``olddraft([index])`` """``olddraft([index])``
previous draft commits previous draft commits