( )⚙ D4391 perf: add function for obtaining manifest revision

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4391

perf: add function for obtaining manifest revision
ClosedPublic

Authored by indygreg on Aug 27 2018, 12:00 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG862d23bc5749: perf: add function for obtaining manifest revision
Summary

This will use the modern API if available or fall back to the
legacy direct revlog access case. Without this, the perf command
won't work on all code bases.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 27 2018, 12:00 PM
Closed by commit rHG862d23bc5749: perf: add function for obtaining manifest revision (authored by indygreg). · Explain WhyAug 29 2018, 1:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (18 lines)

Diff 10632

contrib/perf.py

else: else:
mdiff.textdiff(*pair) mdiff.textdiff(*pair)
q.task_done() q.task_done()
pair = q.get() pair = q.get()
q.task_done() # for the None one q.task_done() # for the None one
with ready: with ready:
ready.wait() ready.wait()
def _manifestrevision(repo, mnode):
ml = repo.manifestlog
if util.safehasattr(ml, 'getstorage'):
store = ml.getstorage(b'')
else:
store = ml._revlog
return store.revision(mnode)
@command('perfbdiff', revlogopts + formatteropts + [ @command('perfbdiff', revlogopts + formatteropts + [
('', 'count', 1, 'number of revisions to test (when using --startrev)'), ('', 'count', 1, 'number of revisions to test (when using --startrev)'),
('', 'alldata', False, 'test bdiffs for all associated revisions'), ('', 'alldata', False, 'test bdiffs for all associated revisions'),
('', 'threads', 0, 'number of thread to use (disable with 0)'), ('', 'threads', 0, 'number of thread to use (disable with 0)'),
('', 'blocks', False, 'test computing diffs into blocks'), ('', 'blocks', False, 'test computing diffs into blocks'),
('', 'xdiff', False, 'use xdiff algorithm'), ('', 'xdiff', False, 'use xdiff algorithm'),
], ],
r = cmdutil.openrevlog(repo, 'perfbdiff', file_, opts) r = cmdutil.openrevlog(repo, 'perfbdiff', file_, opts)
startrev = r.rev(r.lookup(rev)) startrev = r.rev(r.lookup(rev))
for rev in range(startrev, min(startrev + count, len(r) - 1)): for rev in range(startrev, min(startrev + count, len(r) - 1)):
if opts['alldata']: if opts['alldata']:
# Load revisions associated with changeset. # Load revisions associated with changeset.
ctx = repo[rev] ctx = repo[rev]
mtext = repo.manifestlog._revlog.revision(ctx.manifestnode()) mtext = _manifestrevision(repo, ctx.manifestnode())
for pctx in ctx.parents(): for pctx in ctx.parents():
pman = repo.manifestlog._revlog.revision(pctx.manifestnode()) pman = _manifestrevision(repo, pctx.manifestnode())
textpairs.append((pman, mtext)) textpairs.append((pman, mtext))
# Load filelog revisions by iterating manifest delta. # Load filelog revisions by iterating manifest delta.
man = ctx.manifest() man = ctx.manifest()
pman = ctx.p1().manifest() pman = ctx.p1().manifest()
for filename, change in pman.diff(man).items(): for filename, change in pman.diff(man).items():
fctx = repo.file(filename) fctx = repo.file(filename)
f1 = fctx.revision(change[0][0] or -1) f1 = fctx.revision(change[0][0] or -1)
r = cmdutil.openrevlog(repo, 'perfunidiff', file_, opts) r = cmdutil.openrevlog(repo, 'perfunidiff', file_, opts)
startrev = r.rev(r.lookup(rev)) startrev = r.rev(r.lookup(rev))
for rev in range(startrev, min(startrev + count, len(r) - 1)): for rev in range(startrev, min(startrev + count, len(r) - 1)):
if opts['alldata']: if opts['alldata']:
# Load revisions associated with changeset. # Load revisions associated with changeset.
ctx = repo[rev] ctx = repo[rev]
mtext = repo.manifestlog._revlog.revision(ctx.manifestnode()) mtext = _manifestrevision(repo, ctx.manifestnode())
for pctx in ctx.parents(): for pctx in ctx.parents():
pman = repo.manifestlog._revlog.revision(pctx.manifestnode()) pman = _manifestrevision(repo, pctx.manifestnode())
textpairs.append((pman, mtext)) textpairs.append((pman, mtext))
# Load filelog revisions by iterating manifest delta. # Load filelog revisions by iterating manifest delta.
man = ctx.manifest() man = ctx.manifest()
pman = ctx.p1().manifest() pman = ctx.p1().manifest()
for filename, change in pman.diff(man).items(): for filename, change in pman.diff(man).items():
fctx = repo.file(filename) fctx = repo.file(filename)
f1 = fctx.revision(change[0][0] or -1) f1 = fctx.revision(change[0][0] or -1)