( )⚙ D4410 revsetlang: fix position of '-' in spaceless 'a-b' expressions

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4410

revsetlang: fix position of '-' in spaceless 'a-b' expressions
ClosedPublic

Authored by martinvonz on Aug 28 2018, 4:30 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb902b177901d: revsetlang: fix position of '-' in spaceless 'a-b' expressions
Summary

I don't know if there is an observable difference, but it seems like
an obvious fix.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Aug 28 2018, 4:30 PM
Closed by commit rHGb902b177901d: revsetlang: fix position of '-' in spaceless 'a-b' expressions (authored by martinvonz). · Explain WhyAug 29 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revsetlang.py (2 lines)

Diff 10622

mercurial/revsetlang.py

yield ('symbol', sym, s) yield ('symbol', sym, s)
else: else:
# looks like an expression # looks like an expression
parts = sym.split('-') parts = sym.split('-')
for p in parts[:-1]: for p in parts[:-1]:
if p: # possible consecutive - if p: # possible consecutive -
yield ('symbol', p, s) yield ('symbol', p, s)
s += len(p) s += len(p)
yield ('-', None, pos) yield ('-', None, s)
s += 1 s += 1
if parts[-1]: # possible trailing - if parts[-1]: # possible trailing -
yield ('symbol', parts[-1], s) yield ('symbol', parts[-1], s)
else: else:
yield ('symbol', sym, s) yield ('symbol', sym, s)
pos -= 1 pos -= 1
else: else:
raise error.ParseError(_("syntax error in revset '%s'") % raise error.ParseError(_("syntax error in revset '%s'") %