This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4454

py3: don't return the revid as unicode in hgext/convert/subversion.py
ClosedPublic

Authored by pulkit on Sep 4 2018, 11:17 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG34fe76b31ca4: py3: don't return the revid as unicode in hgext/convert/subversion.py
Summary

I tried digging why u'' was added in first place, and I was unable to found
something relevant. This might be because some API's takes unicodes, I am not
sure.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mhgext/convert/subversion.py (2 lines)

Diff 10744

hgext/convert/subversion.py

self.manifest.update(files) self.manifest.update(files)
self.xargs(files, 'add', quiet=True) self.xargs(files, 'add', quiet=True)
return files return files
def addchild(self, parent, child): def addchild(self, parent, child):
self.childmap[parent] = child self.childmap[parent] = child
def revid(self, rev): def revid(self, rev):
return u"svn:%s@%s" % (self.uuid, rev) return "svn:%s@%s" % (self.uuid, rev)
def putcommit(self, files, copies, parents, commit, source, revmap, full, def putcommit(self, files, copies, parents, commit, source, revmap, full,
cleanp2): cleanp2):
for parent in parents: for parent in parents:
try: try:
return self.revid(self.childmap[parent]) return self.revid(self.childmap[parent])
except KeyError: except KeyError:
pass pass