This is an archive of the discontinued Mercurial Phabricator instance.

Differential D45

tests: add devel-warning to remotenames output
ClosedPublic

Authored by mitrandir on Jul 11 2017, 12:12 PM.
Tags
None
Subscribers
quark

Details

Reviewers
quark
Commits
rFBHGXc89e2429eb20: tests: add devel-warning to remotenames output
Summary

Will be tehre until remotenames are fixed

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

mitrandir created this revision.Jul 11 2017, 12:12 PM
quark requested changes to this revision.Jul 11 2017, 12:31 PM
quark added a subscriber: quark.
quark added inline comments.
tests/test-pushrebase-remotenames.t
431

The path contains your name. This needs to be a glob.

This revision now requires changes to proceed.Jul 11 2017, 12:31 PM
mitrandir added inline comments.Jul 11 2017, 12:32 PM
tests/test-pushrebase-remotenames.t
431

goodcatch

mitrandir edited edge metadata.Jul 11 2017, 12:35 PM
mitrandir updated this revision to Diff 63.

removed my username from path in favor of glob, retested

quark accepted this revision.Jul 11 2017, 12:40 PM
This revision is now accepted and ready to land.Jul 11 2017, 12:40 PM
quark added a comment.Jul 11 2017, 12:40 PM

Note: run phabsend again will update existing diffs if you didn't remove the tags.

mitrandir added a comment.Jul 11 2017, 12:42 PM

pahbsend works in a very magical way - I'm a bit scared of using it. Also: arcanist is fast in such a small repo :)

mitrandir closed this revision.Jul 11 2017, 1:25 PM

Revision Contents
Changeset List

Diff 63

tests/test-pushrebase-remotenames.t

> [experimental] > [experimental]
> bundle2-exp=True > bundle2-exp=True
> EOF > EOF
$ hg book clientfeature -t default/serverfeature $ hg book clientfeature -t default/serverfeature
$ echo b > b && hg commit -Aqm b $ echo b > b && hg commit -Aqm b
$ hg push --to serverfeature $ hg push --to serverfeature
pushing rev d2ae7f538514 to destination ssh://user@dummy/pushrebaseserver bookmark serverfeature pushing rev d2ae7f538514 to destination ssh://user@dummy/pushrebaseserver bookmark serverfeature
searching for changes searching for changes
devel-warn: obsolete.foreground moved to obsutil.foreground
(compatibility will be dropped after Mercurial-4.3, update your code.) at: *:913 (expushdiscoverybookmarks) (glob)
quarkUnsubmitted
Not Done

The path contains your name. This needs to be a glob.

quark: The path contains your name. This needs to be a glob.
mitrandirAuthorUnsubmitted
Not Done

goodcatch

mitrandir: goodcatch
remote: error: prechangegroup.blocknonpushrebase hook failed: this repository requires that you enable the pushrebase extension and push using 'hg push --to' remote: error: prechangegroup.blocknonpushrebase hook failed: this repository requires that you enable the pushrebase extension and push using 'hg push --to'
remote: this repository requires that you enable the pushrebase extension and push using 'hg push --to' remote: this repository requires that you enable the pushrebase extension and push using 'hg push --to'
abort: push failed on remote abort: push failed on remote
[255] [255]
Remotenames are turned off and bundle1 is enabled Remotenames are turned off and bundle1 is enabled
$ cd .. $ cd ..
$ cat >> client/.hg/hgrc <<EOF $ cat >> client/.hg/hgrc <<EOF