Page MenuHomePhabricator

tests: add devel-warning to remotenames output
ClosedPublic

Authored by mitrandir on Jul 11 2017, 12:12 PM.

Details

Summary

Will be tehre until remotenames are fixed

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

mitrandir created this revision.Jul 11 2017, 12:12 PM
quark requested changes to this revision.Jul 11 2017, 12:31 PM
quark added a subscriber: quark.
quark added inline comments.
tests/test-pushrebase-remotenames.t
431

The path contains your name. This needs to be a glob.

This revision now requires changes to proceed.Jul 11 2017, 12:31 PM
mitrandir added inline comments.Jul 11 2017, 12:32 PM
tests/test-pushrebase-remotenames.t
431

goodcatch

mitrandir edited edge metadata.Jul 11 2017, 12:35 PM
mitrandir updated this revision to Diff 63.

removed my username from path in favor of glob, retested

quark accepted this revision.Jul 11 2017, 12:40 PM
This revision is now accepted and ready to land.Jul 11 2017, 12:40 PM

Note: run phabsend again will update existing diffs if you didn't remove the tags.

pahbsend works in a very magical way - I'm a bit scared of using it. Also: arcanist is fast in such a small repo :)

mitrandir closed this revision.Jul 11 2017, 1:25 PM