This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4506

util: update lrucachedict order during get()
ClosedPublic

Authored by indygreg on Sep 7 2018, 1:18 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8f2c0d1b454c: util: update lrucachedict order during get()
Summary

get() should have the same semantics as getitem for item
retrieval.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 7 2018, 1:18 PM
Closed by commit rHG8f2c0d1b454c: util: update lrucachedict order during get() (authored by indygreg). · Explain WhySep 12 2018, 10:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (2 lines)
Mtests/test-lrucachedict.py (12 lines)

Diff 10945

mercurial/util.py

# this node the oldest item. # this node the oldest item.
self._movetohead(node) self._movetohead(node)
self._head = node.next self._head = node.next
# Additional dict methods. # Additional dict methods.
def get(self, k, default=None): def get(self, k, default=None):
try: try:
return self._cache[k].value return self.__getitem__(k)
except KeyError: except KeyError:
return default return default
def clear(self): def clear(self):
n = self._head n = self._head
while n.key is not _notset: while n.key is not _notset:
self.totalcost -= n.cost self.totalcost -= n.cost
n.markempty() n.markempty()

tests/test-lrucachedict.py

d['a'] = 1 d['a'] = 1
d['b'] = 2 d['b'] = 2
d['a'] d['a']
d['b'] d['b']
for key in ('a', 'b'): for key in ('a', 'b'):
self.assertIn(key, d) self.assertIn(key, d)
def testget(self):
d = util.lrucachedict(4)
d['a'] = 'va'
d['b'] = 'vb'
d['c'] = 'vc'
self.assertIsNone(d.get('missing'))
self.assertEqual(list(d), ['c', 'b', 'a'])
self.assertEqual(d.get('a'), 'va')
self.assertEqual(list(d), ['a', 'c', 'b'])
def testcopypartial(self): def testcopypartial(self):
d = util.lrucachedict(4) d = util.lrucachedict(4)
d.insert('a', 'va', cost=4) d.insert('a', 'va', cost=4)
d.insert('b', 'vb', cost=2) d.insert('b', 'vb', cost=2)
dc = d.copy() dc = d.copy()
self.assertEqual(len(dc), 2) self.assertEqual(len(dc), 2)