This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4542

fastannotate: use repo.local()
ClosedPublic

Authored by indygreg on Sep 11 2018, 8:33 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG2182e67ea912: fastannotate: use repo.local()
Summary

This is the proper way to check whether we're dealing with a local
repository, since extensions should be coding to an interface and
not testing for exact types.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 11 2018, 8:33 PM
pulkit accepted this revision.Sep 12 2018, 7:41 AM
pulkit added inline comments.Sep 12 2018, 8:31 AM
hgext/fastannotate/protocol.py
17

Dropped this import in flight to make pyflakes happy.

Closed by commit rHG2182e67ea912: fastannotate: use repo.local() (authored by indygreg). · Explain WhySep 12 2018, 8:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fastannotate/protocol.py (3 lines)

Diff 10920

hgext/fastannotate/protocol.py

# Copyright 2016-present Facebook. All Rights Reserved. # Copyright 2016-present Facebook. All Rights Reserved.
# #
# protocol: logic for a server providing fastannotate support # protocol: logic for a server providing fastannotate support
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
import contextlib import contextlib
import os import os
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
error, error,
extensions, extensions,
hg, hg,
localrepo,
pulkitUnsubmitted
Not Done

Dropped this import in flight to make pyflakes happy.

pulkit: Dropped this import in flight to make pyflakes happy.
util, util,
wireprotov1peer, wireprotov1peer,
wireprotov1server, wireprotov1server,
) )
from . import context from . import context
# common # common
clientfetch(self, needupdatepaths, lastnodemap, peer) clientfetch(self, needupdatepaths, lastnodemap, peer)
except Exception as ex: except Exception as ex:
# could be directory not writable or so, not fatal # could be directory not writable or so, not fatal
self.ui.debug('fastannotate: prefetch failed: %r\n' % ex) self.ui.debug('fastannotate: prefetch failed: %r\n' % ex)
repo.__class__ = fastannotaterepo repo.__class__ = fastannotaterepo
def clientreposetup(ui, repo): def clientreposetup(ui, repo):
_registerwireprotocommand() _registerwireprotocommand()
if isinstance(repo, localrepo.localrepository): if repo.local():
localreposetup(ui, repo) localreposetup(ui, repo)
# TODO: this mutates global state, but only if at least one repo # TODO: this mutates global state, but only if at least one repo
# has the extension enabled. This is probably bad for hgweb. # has the extension enabled. This is probably bad for hgweb.
if peersetup not in hg.wirepeersetupfuncs: if peersetup not in hg.wirepeersetupfuncs:
hg.wirepeersetupfuncs.append(peersetup) hg.wirepeersetupfuncs.append(peersetup)