This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4550

localrepo: use urllocalpath() for path to create repo too
ClosedPublic

Authored by martinvonz on Sep 12 2018, 3:23 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG76b58f240821: localrepo: use urllocalpath() for path to create repo too
Summary

It looks like this was lost in 7ce9dea3a14a (localrepo: move repo
creation logic out of localrepository.init (API), 2018-09-11). I
don't know when it makes a difference (maybe on Windows, since
urllocalpath() mentions something about drive letters).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 12 2018, 3:23 PM
martinvonz updated this revision to Diff 10978.Sep 12 2018, 5:50 PM
Closed by commit rHG76b58f240821: localrepo: use urllocalpath() for path to create repo too (authored by martinvonz). · Explain WhySep 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (5 lines)

Diff 10982

mercurial/localrepo.py

return a return a
def undoname(fn): def undoname(fn):
base, name = os.path.split(fn) base, name = os.path.split(fn)
assert name.startswith('journal') assert name.startswith('journal')
return os.path.join(base, name.replace('journal', 'undo', 1)) return os.path.join(base, name.replace('journal', 'undo', 1))
def instance(ui, path, create, intents=None, createopts=None): def instance(ui, path, create, intents=None, createopts=None):
localpath = util.urllocalpath(path)
if create: if create:
createrepository(ui, path, createopts=createopts) createrepository(ui, localpath, createopts=createopts)
return localrepository(ui, util.urllocalpath(path), intents=intents) return localrepository(ui, localpath, intents=intents)
def islocal(path): def islocal(path):
return True return True
def newreporequirements(ui, createopts=None): def newreporequirements(ui, createopts=None):
"""Determine the set of requirements for a new local repository. """Determine the set of requirements for a new local repository.
Extensions can wrap this function to specify custom requirements for Extensions can wrap this function to specify custom requirements for