This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4552

shelve: use bundlerepo.instance() to construct a repo object
ClosedPublic

Authored by indygreg on Sep 12 2018, 10:02 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG84d6e9a2b104: shelve: use bundlerepo.instance() to construct a repo object
Summary

The instance() functions are preferred over cls.init for
creating repo instances. It doesn't really matter now. But future
commits will refactor the bundlerepository class in ways that will
cause the old way to break.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Sep 12 2018, 10:02 PM
Closed by commit rHG84d6e9a2b104: shelve: use bundlerepo.instance() to construct a repo object (authored by indygreg). · Explain WhySep 13 2018, 11:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/shelve.py (6 lines)

Diff 10984

hgext/shelve.py

bundle2.applybundle(self.repo, gen, self.repo.currenttransaction(), bundle2.applybundle(self.repo, gen, self.repo.currenttransaction(),
source='unshelve', source='unshelve',
url='bundle:' + self.vfs.join(self.fname), url='bundle:' + self.vfs.join(self.fname),
targetphase=targetphase) targetphase=targetphase)
finally: finally:
fp.close() fp.close()
def bundlerepo(self): def bundlerepo(self):
return bundlerepo.bundlerepository(self.repo.baseui, self.repo.root, path = self.vfs.join(self.fname)
self.vfs.join(self.fname)) return bundlerepo.instance(self.repo.baseui,
'bundle://%s+%s' % (self.repo.root, path))
def writebundle(self, bases, node): def writebundle(self, bases, node):
cgversion = changegroup.safeversion(self.repo) cgversion = changegroup.safeversion(self.repo)
if cgversion == '01': if cgversion == '01':
btype = 'HG10BZ' btype = 'HG10BZ'
compression = None compression = None
else: else:
btype = 'HG20' btype = 'HG20'
compression = 'BZ' compression = 'BZ'