This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4636

changegroup: improve the devel-warn to specify changelog was empty
ClosedPublic

Authored by pulkit on Sep 18 2018, 6:43 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG9b07ee0a1054: changegroup: improve the devel-warn to specify changelog was empty
Summary

Right now, the develwarn says "applied empty changegroup" which is not correct
because we can send a changegroup without changelog with just manifest and
filelogs and it will still say the same.

Let's fix this to say that we are applying empty changelog from changegroup. In
future patches I am will be adding functionality to send a changegroup from the
server without an empty changelog.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (2 lines)

Diff 11143

mercurial/changegroup.py

efiles.update(cl.readfiles(node)) efiles.update(cl.readfiles(node))
self.changelogheader() self.changelogheader()
deltas = self.deltaiter() deltas = self.deltaiter()
cgnodes = cl.addgroup(deltas, csmap, trp, addrevisioncb=onchangelog) cgnodes = cl.addgroup(deltas, csmap, trp, addrevisioncb=onchangelog)
efiles = len(efiles) efiles = len(efiles)
if not cgnodes: if not cgnodes:
repo.ui.develwarn('applied empty changegroup', repo.ui.develwarn('applied empty changelog from changegroup',
config='warn-empty-changegroup') config='warn-empty-changegroup')
clend = len(cl) clend = len(cl)
changesets = clend - clstart changesets = clend - clstart
progress.complete() progress.complete()
self.callback = None self.callback = None
# pull off the manifest group # pull off the manifest group
repo.ui.status(_("adding manifests\n")) repo.ui.status(_("adding manifests\n"))