This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4640

narrow: add test showing that local-to-local narrow clones don't work
ClosedPublic

Authored by durin42 on Sep 18 2018, 5:22 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4dca2e028f0a: narrow: add test showing that local-to-local narrow clones don't work
rHGb990f5a31e6b: narrow: add test showing that local-to-local narrow clones don't work
Summary

It turns out they've never actually worked: prior to some recent
refactoring they just unintentionally followed the full-clone path,
which we unintentionally relied on in a test at Google.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 18 2018, 5:22 PM
yuja added a subscriber: yuja.Sep 20 2018, 7:58 AM

+ $ rm -r narrow-via-localpeer
+ rm: narrow-via-localpeer: $ENOENT$
+ [1]

Changed this to rm -Rf and queued, thanks. It appears that GNU rm shows
friendlier message.

Closed by commit rHGb990f5a31e6b: narrow: add test showing that local-to-local narrow clones don't work (authored by durin42). · Explain WhySep 20 2018, 8:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-narrow-clone.t (11 lines)

Diff 11206

tests/test-narrow-clone.t

dir dir
dir/src dir/src
dir/src/f10 dir/src/f10
$ cat dir/src/f10 $ cat dir/src/f10
10 10
$ cd .. $ cd ..
BUG: local-to-local narrow clones should work, but don't.
$ hg clone --narrow master narrow-via-localpeer --noupdate --include "dir/src/f10"
requesting all changes
abort: server doesn't support narrow clones
[255]
$ hg tracked -R narrow-via-localpeer
abort: repository narrow-via-localpeer not found!
[255]
$ rm -Rf narrow-via-localpeer
narrow clone with a newline should fail narrow clone with a newline should fail
$ hg clone --narrow ssh://user@dummy/master narrow_fail --noupdate --include 'dir/src/f10 $ hg clone --narrow ssh://user@dummy/master narrow_fail --noupdate --include 'dir/src/f10
> ' > '
abort: newlines are not allowed in narrowspec paths abort: newlines are not allowed in narrowspec paths
[255] [255]
narrow clone a directory, tests/, except tests/t19 narrow clone a directory, tests/, except tests/t19