This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4659

filelog: stop proxying _addrevision() (API)
ClosedPublic

Authored by indygreg on Sep 18 2018, 10:34 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG87eeb6966220: filelog: stop proxying _addrevision() (API)
Summary

There are no callers of this API in core. And I'm not sure why this
proxy was added in the first place, as the commit that added it
(1541e1a8e87d) didn't appear to have any callers in the repo either.
Who knows.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 18 2018, 10:34 PM
Closed by commit rHG87eeb6966220: filelog: stop proxying _addrevision() (API) (authored by indygreg). · Explain WhySep 23 2018, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/filelog.py (3 lines)

Diff 11285

mercurial/filelog.py

return self._revlog.opener return self._revlog.opener
def clone(self, tr, destrevlog, **kwargs): def clone(self, tr, destrevlog, **kwargs):
if not isinstance(destrevlog, filelog): if not isinstance(destrevlog, filelog):
raise error.ProgrammingError('expected filelog to clone()') raise error.ProgrammingError('expected filelog to clone()')
return self._revlog.clone(tr, destrevlog._revlog, **kwargs) return self._revlog.clone(tr, destrevlog._revlog, **kwargs)
def _addrevision(self, *args, **kwargs):
return self._revlog._addrevision(*args, **kwargs)
class narrowfilelog(filelog): class narrowfilelog(filelog):
"""Filelog variation to be used with narrow stores.""" """Filelog variation to be used with narrow stores."""
def __init__(self, opener, path, narrowmatch): def __init__(self, opener, path, narrowmatch):
super(narrowfilelog, self).__init__(opener, path) super(narrowfilelog, self).__init__(opener, path)
self._narrowmatch = narrowmatch self._narrowmatch = narrowmatch
def renamed(self, node): def renamed(self, node):