( )⚙ D4662 hgweb: use heads() instead of headrevs()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4662

hgweb: use heads() instead of headrevs()
ClosedPublic

Authored by indygreg on Sep 18 2018, 10:34 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbe0f32ca2671: hgweb: use heads() instead of headrevs()
Summary

These appear to be the only callers of headrevs() on file storage
objects. Let's port to heads() so we can remove headrevs().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 18 2018, 10:34 PM
Closed by commit rHGbe0f32ca2671: hgweb: use heads() instead of headrevs() (authored by indygreg). · Explain WhySep 23 2018, 6:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webcommands.py (4 lines)

Diff 11288

mercurial/hgweb/webcommands.py

web.res.headers['Content-Disposition'] = 'inline; filename="%s"' % filename web.res.headers['Content-Disposition'] = 'inline; filename="%s"' % filename
web.res.setbodybytes(text) web.res.setbodybytes(text)
return web.res.sendresponse() return web.res.sendresponse()
def _filerevision(web, fctx): def _filerevision(web, fctx):
f = fctx.path() f = fctx.path()
text = fctx.data() text = fctx.data()
parity = paritygen(web.stripecount) parity = paritygen(web.stripecount)
ishead = fctx.filerev() in fctx.filelog().headrevs() ishead = fctx.filenode() in fctx.filelog().heads()
if stringutil.binary(text): if stringutil.binary(text):
mt = mimetypes.guess_type(f)[0] or 'application/octet-stream' mt = mimetypes.guess_type(f)[0] or 'application/octet-stream'
text = '(binary:%s)' % mt text = '(binary:%s)' % mt
def lines(context): def lines(context):
for lineno, t in enumerate(text.splitlines(True)): for lineno, t in enumerate(text.splitlines(True)):
yield {"line": t, yield {"line": t,
false and ``1`` and ``true`` are true. If not defined, the server false and ``1`` and ``true`` are true. If not defined, the server
default settings are used. default settings are used.
The ``fileannotate`` template is rendered. The ``fileannotate`` template is rendered.
""" """
fctx = webutil.filectx(web.repo, web.req) fctx = webutil.filectx(web.repo, web.req)
f = fctx.path() f = fctx.path()
parity = paritygen(web.stripecount) parity = paritygen(web.stripecount)
ishead = fctx.filerev() in fctx.filelog().headrevs() ishead = fctx.filenode() in fctx.filelog().heads()
# parents() is called once per line and several lines likely belong to # parents() is called once per line and several lines likely belong to
# same revision. So it is worth caching. # same revision. So it is worth caching.
# TODO there are still redundant operations within basefilectx.parents() # TODO there are still redundant operations within basefilectx.parents()
# and from the fctx.annotate() call itself that could be cached. # and from the fctx.annotate() call itself that could be cached.
parentscache = {} parentscache = {}
def parents(context, f): def parents(context, f):
rev = f.rev() rev = f.rev()